mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-11-28 21:20:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

coverity/15010: Remove dead code. #829

Browse Source 
In win_close_othertab: Code can never be reached because of a
logical contradiction (CWE-561).
Pointer tp cannot be NULL at this point, so conditional operator ? can
be replaced with its second expression.
This commit is contained in:
oni-link
2014-06-11 10:03:48 +02:00
committed by Justin M. Keyes
parent 4ccf1125ff
commit 90385163d5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/window.c
View File

@@ -1932,7 +1932,7 @@ void win_close_othertab(win_T *win, int free_buf, tabpage_T *tp)
return; return;
/* When closing the last window in a tab page remove the tab page. */ /* When closing the last window in a tab page remove the tab page. */
if (tp == NULL ? firstwin == lastwin : tp->tp_firstwin == tp->tp_lastwin) { if (tp->tp_firstwin == tp->tp_lastwin) {
if (tp == first_tabpage) if (tp == first_tabpage)
first_tabpage = tp->tp_next; first_tabpage = tp->tp_next;
else { else {