From c065b0d75f3039030ca7de36397585c66542574b Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Sun, 20 Oct 2019 22:36:30 -0400 Subject: [PATCH 1/3] CI: bump nodejs to v10.x (LTS) v8.x will be EOL at end of 2019. nvm on Travis has outdated LTS aliases. --- appveyor.yml | 2 +- ci/before_install.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index bb7bb1c4e9..7e2aef345b 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -24,7 +24,7 @@ matrix: fast_finish: true install: [] before_build: -- ps: Install-Product node 8 +- ps: Install-Product node 10 build_script: - powershell ci\build.ps1 after_build: diff --git a/ci/before_install.sh b/ci/before_install.sh index 283605e113..7e2ff12d6d 100755 --- a/ci/before_install.sh +++ b/ci/before_install.sh @@ -47,8 +47,8 @@ if [[ "${TRAVIS_OS_NAME}" == osx ]] || [ ! -f ~/.nvm/nvm.sh ]; then fi source ~/.nvm/nvm.sh -nvm install --lts -nvm use --lts +nvm install 10 +nvm use 10 if [[ -n "$CMAKE_URL" ]]; then echo "Installing custom CMake: $CMAKE_URL" From 9b22b69454de45d37ae0bd5ebbefa8538d36197f Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Tue, 22 Oct 2019 20:28:56 -0400 Subject: [PATCH 2/3] CI/Appveyor: set powershell strict mode Set-PSDebug produces too much noise and has global scope. Strict mode is scoped to the script context and catches errors. --- ci/build.ps1 | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ci/build.ps1 b/ci/build.ps1 index 6d91b97aed..8f7fdd5f59 100644 --- a/ci/build.ps1 +++ b/ci/build.ps1 @@ -1,10 +1,10 @@ +Set-StrictMode -Version Latest $ErrorActionPreference = 'stop' -Set-PSDebug -Strict -Trace 1 $isPullRequest = ($env:APPVEYOR_PULL_REQUEST_HEAD_COMMIT -ne $null) $env:CONFIGURATION -match '^(?\w+)_(?32|64)(?:-(?