mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 03:18:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.0259: crash with mouse click when not initialized (#21282)

Browse Source 
Problem:    Crash with mouse click when not initialized.
Solution:   Check TabPageIdxs[] is not NULL.

80525751c5

Co-authored-by: Bram Moolenaar <Bram@vim.org>
This commit is contained in:
zeertzjq
2022-12-04 17:44:51 +08:00
committed by GitHub
parent 823247a040
commit 9263f17d0d
2 changed files with 73 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/mouse.c
View File

@@ -467,6 +467,7 @@ bool do_mouse(oparg_T *oap, int c, int dir, long count, bool fixindent)
start_visual.lnum = 0; start_visual.lnum = 0;
if (tab_page_click_defs != NULL) { // only when initialized
// Check for clicking in the tab page line. // Check for clicking in the tab page line.
if (mouse_grid <= 1 && mouse_row == 0 && firstwin->w_winrow > 0) { if (mouse_grid <= 1 && mouse_row == 0 && firstwin->w_winrow > 0) {
if (is_drag) { if (is_drag) {
@@ -528,6 +529,7 @@ bool do_mouse(oparg_T *oap, int c, int dir, long count, bool fixindent)
move_tab_to_mouse(); move_tab_to_mouse();
return false; return false;
} }
}
// When 'mousemodel' is "popup" or "popup_setpos", translate mouse events: // When 'mousemodel' is "popup" or "popup_setpos", translate mouse events:
// right button up -> pop-up menu // right button up -> pop-up menu

14
src/nvim/testdir/test_tabline.vim
View File

@@ -147,4 +147,18 @@ func Test_tabline_20_format_items_no_overrun()
set showtabline& tabline& set showtabline& tabline&
endfunc endfunc
func Test_mouse_click_in_tab()
" This used to crash because TabPageIdxs[] was not initialized
let lines =<< trim END
tabnew
set mouse=a
exe "norm \<LeftMouse>"
END
call writefile(lines, 'Xclickscript')
call RunVim([], [], "-e -s -S Xclickscript -c qa")
call delete('Xclickscript')
endfunc
" vim: shiftwidth=2 sts=2 expandtab " vim: shiftwidth=2 sts=2 expandtab