Enable -Wconversion: indent.c.

Note: Clint was failing because of recommending not to use long. But
converting to long is the proper refactoring here, in as far as other
longs exist. We could, then, disable clint rule, or remove this file
from checking. We choose the former, as it's being discussed what to do
with longs, but a decision has not been taken. So, it seems most
reasonable to allow longs for now, to enable proper refactorings, and
then, when a decision is taken, refactor all longs to some other thing.
This commit is contained in:
Eliseo Martínez
2015-02-12 16:11:04 +01:00
committed by Justin M. Keyes
parent 7dd48d7af0
commit 94db26edbd
3 changed files with 9 additions and 6 deletions

View File

@@ -2776,7 +2776,7 @@ def CheckLanguage(filename, clean_lines, linenum, file_extension,
# TODO(unknown): figure out if they're using default arguments in fn proto.
# Check if people are using the verboten C basic types.
match = Search(r'\b(short|long(?! +double)|long long)\b', line)
match = Search(r'\b(short|long long)\b', line)
if match:
error(filename, linenum, 'runtime/int', 4,
'Use int16_t/int64_t/etc, rather than the C type %s'