mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-06-15 16:23:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(xxd): buffer overread #40236

Browse Source 
Problem
Buffer overflow if lines exceed the expected buffer size.

Solution:
Use snprintf instead of strcpy.
This commit is contained in:
OrbisAI Security
2026-06-14 20:46:02 +05:30
committed by GitHub
parent 3d6393540e
commit 966e7a98f5
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xxd/xxd.c
View File

@@ -573,7 +573,7 @@ static void xxdline(FILE *fp, char *l, char *colors, int nz)
static signed char zero_seen = 0;
if (!nz && zero_seen == 1) {
strcpy(z, l);
snprintf(z, sizeof(z), "%s", l);
if (colors) {
memcpy(z_colors, colors, strlen(z));
}

8
test/functional/editor/xxd_spec.lua
View File

@@ -2,6 +2,7 @@ local t = require('test.testutil')
local n = require('test.functional.testnvim')()
local eq = t.eq
local eval = n.eval
local clear = n.clear
local fn = n.fn
local testprg = n.testprg
@@ -17,4 +18,11 @@ describe('xxd', function()
local decoded = fn.system({ testprg('xxd'), '-r' }, encoded)
eq(input, decoded)
end)
it('handles long lines in revert mode', function()
t.skip(t.is_arch('s390x'), 'FIXME: xxd not built correctly on s390x with QEMU?')
local long_line = ('4'):rep(512) .. '\n'
fn.system({ testprg('xxd'), '-r' }, long_line)
eq(0, eval('v:shell_error'))
end)
end)