mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-11-22 18:16:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(column): modifying a sign should update placed signs (#29750)

Browse Source 
Problem:  Modifying a sign no longer updates already placed signs.
Solution: Loop over (newly-exposed) placed decorations when modifying a
          sign definition. Update placed decor if it belongs to the sign
          that is modified.
(cherry picked from commit f9a49fab0c)
This commit is contained in:
luukvbaal
2024-07-17 02:53:10 +02:00
committed by github-actions[bot]
parent 2fb69ccaf7
commit 97be9d8563
4 changed files with 76 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
test/functional/legacy/signs_spec.lua
View File

@@ -1,13 +1,14 @@
-- Tests for signs
local n = require('test.functional.testnvim')()
local Screen = require('test.functional.ui.screen')
local clear, command, expect = n.clear, n.command, n.expect
local clear, command, exec, expect, feed = n.clear, n.command, n.exec, n.expect, n.feed
describe('signs', function()
setup(clear)
before_each(clear)
it('is working', function()
it('are working', function()
command('sign define JumpSign text=x')
command([[exe 'sign place 42 line=2 name=JumpSign buffer=' . bufnr('')]])
-- Split the window to the bottom to verify :sign-jump will stay in the current
@@ -21,4 +22,47 @@ describe('signs', function()
2]])
end)
-- oldtest: Test_sign_cursor_position()
it('are drawn correctly', function()
local screen = Screen.new(75, 6)
screen:attach()
exec([[
call setline(1, [repeat('x', 75), 'mmmm', 'yyyy'])
call cursor(2,1)
sign define s1 texthl=Search text==>
redraw
sign place 10 line=2 name=s1
]])
screen:expect([[
{7: }xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx|
{7: }xx |
{10:=>}^mmmm |
{7: }yyyy |
{1:~ }|
|
]])
-- Change the sign text
command('sign define s1 text=-)')
screen:expect([[
{7: }xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx|
{7: }xx |
{10:-)}^mmmm |
{7: }yyyy |
{1:~ }|
|
]])
-- update cursor position calculation
feed('lh')
command('sign unplace 10')
screen:expect([[
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx|
^mmmm |
yyyy |
{1:~ }|*2
|
]])
end)
end)