mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-28 22:18:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

I/O: ignore ENOTSUP for failed fsync()

Browse Source 
Suggested by ZyX in https://github.com/neovim/neovim/issues/6725#issuecomment-312197691 :
> There already is an exception if writing to a “device” (e.g. FIFO).
> It makes sense to ignore certain errors like ENOTSUP or EOPNOTSUPP
> since it is not something we or user can do anything about.

ref #6725
This commit is contained in:
Justin M. Keyes
2019-02-20 21:52:12 +01:00
parent c59aa771a6
commit 996916277d
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/fileio.c
View File

@@ -3405,7 +3405,9 @@ restore_backup:
// (could be a pipe).
// If the 'fsync' option is FALSE, don't fsync(). Useful for laptops.
int error;
if (p_fs && (error = os_fsync(fd)) != 0 && !device) {
if (p_fs && (error = os_fsync(fd)) != 0 && !device
// fsync not supported on this storage.
&& error != UV_ENOTSUP) {
SET_ERRMSG_ARG(_("E667: Fsync failed: %s"), error);
end = 0;
}

5
src/nvim/os/fileio.c
View File

@@ -229,7 +229,10 @@ int file_fsync(FileDescriptor *const fp)
return flush_error;
}
const int fsync_error = os_fsync(fp->fd);
if (fsync_error != UV_EINVAL && fsync_error != UV_EROFS) {
if (fsync_error != UV_EINVAL
&& fsync_error != UV_EROFS
// fsync not supported on this storage.
&& fsync_error != UV_ENOTSUP) {
return fsync_error;
}
return 0;