mirror of
https://github.com/neovim/neovim.git
synced 2025-11-17 15:51:32 +00:00
vim-patch:9.0.2044: Vim9: exceptions confuse defered functions
Problem: Vim9: exceptions confuse defered functions
Solution: save and restore exception state when calling defered
functions
closes: vim/vim#13364
closes: vim/vim#13372
0672595fd5
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
This commit is contained in:
@@ -3296,8 +3296,23 @@ static void handle_defer_one(funccall_T *funccal)
|
|||||||
char *name = dr->dr_name;
|
char *name = dr->dr_name;
|
||||||
dr->dr_name = NULL;
|
dr->dr_name = NULL;
|
||||||
|
|
||||||
|
// If the deferred function is called after an exception, then only the
|
||||||
|
// first statement in the function will be executed. Save and restore
|
||||||
|
// the try/catch/throw exception state.
|
||||||
|
const int save_trylevel = trylevel;
|
||||||
|
const bool save_did_throw = did_throw;
|
||||||
|
const bool save_need_rethrow = need_rethrow;
|
||||||
|
|
||||||
|
trylevel = 0;
|
||||||
|
did_throw = false;
|
||||||
|
need_rethrow = false;
|
||||||
|
|
||||||
call_func(name, -1, &rettv, dr->dr_argcount, dr->dr_argvars, &funcexe);
|
call_func(name, -1, &rettv, dr->dr_argcount, dr->dr_argvars, &funcexe);
|
||||||
|
|
||||||
|
trylevel = save_trylevel;
|
||||||
|
did_throw = save_did_throw;
|
||||||
|
need_rethrow = save_need_rethrow;
|
||||||
|
|
||||||
tv_clear(&rettv);
|
tv_clear(&rettv);
|
||||||
xfree(name);
|
xfree(name);
|
||||||
for (int i = dr->dr_argcount - 1; i >= 0; i--) {
|
for (int i = dr->dr_argcount - 1; i >= 0; i--) {
|
||||||
|
|||||||
@@ -793,5 +793,31 @@ func Test_defer_wrong_arguments()
|
|||||||
call v9.CheckScriptFailure(lines, 'E1013: Argument 1: type mismatch, expected string but got number')
|
call v9.CheckScriptFailure(lines, 'E1013: Argument 1: type mismatch, expected string but got number')
|
||||||
endfunc
|
endfunc
|
||||||
|
|
||||||
|
" Test for calling a deferred function after an exception
|
||||||
|
func Test_defer_after_exception()
|
||||||
|
let g:callTrace = []
|
||||||
|
func Defer()
|
||||||
|
let g:callTrace += ['a']
|
||||||
|
let g:callTrace += ['b']
|
||||||
|
let g:callTrace += ['c']
|
||||||
|
let g:callTrace += ['d']
|
||||||
|
endfunc
|
||||||
|
|
||||||
|
func Foo()
|
||||||
|
defer Defer()
|
||||||
|
throw "TestException"
|
||||||
|
endfunc
|
||||||
|
|
||||||
|
try
|
||||||
|
call Foo()
|
||||||
|
catch /TestException/
|
||||||
|
let g:callTrace += ['e']
|
||||||
|
endtry
|
||||||
|
call assert_equal(['a', 'b', 'c', 'd', 'e'], g:callTrace)
|
||||||
|
|
||||||
|
delfunc Defer
|
||||||
|
delfunc Foo
|
||||||
|
unlet g:callTrace
|
||||||
|
endfunc
|
||||||
|
|
||||||
" vim: shiftwidth=2 sts=2 expandtab
|
" vim: shiftwidth=2 sts=2 expandtab
|
||||||
|
|||||||
Reference in New Issue
Block a user