clint: detect MAYBE and recommend TriState

Vim uses MAYBE for 3-value boolean with FALSE/TRUE/MAYBE.
Use TriState type instead to restrict to 3 values, kFalse/kTrue/kNone.
This commit is contained in:
Jan Edmund Lazo
2018-07-15 22:12:47 -04:00
parent a2253744c9
commit a095a48987

View File

@@ -3299,6 +3299,13 @@ def CheckLanguage(filename, clean_lines, linenum, file_extension,
error(filename, linenum, 'readability/bool', 4,
'Use %s instead of %s.' % (token.lower(), token))
# Detect MAYBE
match = Search(r'\b(MAYBE)\b', line)
if match:
token = match.group(1)
error(filename, linenum, 'readability/bool', 4,
'Use kNONE from TriState instead of %s.' % token)
# Detect preincrement/predecrement
match = Match(r'^\s*(?:\+\+|--)', line)
if match: