refactor: object_to_vim() cannot fail

Since the parent commit, object_to_vim() can't fail, so callers don't
need to check its result.
This commit is contained in:
Justin M. Keyes
2023-12-07 13:01:42 +01:00
parent cca6c4c698
commit a16218d4c6
7 changed files with 15 additions and 46 deletions

View File

@@ -355,10 +355,7 @@ static void api_wrapper(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
goto end;
}
if (!object_to_vim(result, rettv, &err)) {
assert(ERROR_SET(&err));
semsg(_("Error converting the call result: %s"), err.msg);
}
object_to_vim(result, rettv, &err);
end:
api_free_array(args);
@@ -428,7 +425,7 @@ static void f_and(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
static void f_api_info(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
{
Dictionary metadata = api_metadata();
(void)object_to_vim(DICTIONARY_OBJ(metadata), rettv, NULL);
object_to_vim(DICTIONARY_OBJ(metadata), rettv, NULL);
}
/// "atan2()" function
@@ -1023,7 +1020,7 @@ static void f_ctxget(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
Dictionary ctx_dict = ctx_to_dict(ctx);
Error err = ERROR_INIT;
(void)object_to_vim(DICTIONARY_OBJ(ctx_dict), rettv, &err);
object_to_vim(DICTIONARY_OBJ(ctx_dict), rettv, &err);
api_free_dictionary(ctx_dict);
api_clear_error(&err);
}
@@ -6751,10 +6748,7 @@ static void f_rpcrequest(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
goto end;
}
if (!object_to_vim(result, rettv, &err)) {
assert(ERROR_SET(&err));
semsg(_("Error converting the call result: %s"), err.msg);
}
object_to_vim(result, rettv, &err);
end:
arena_mem_free(res_mem);