mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-24 12:08:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): Windows :detach is opt-in

Browse Source 
Problem:
On Windows, spawning the `nvim --embed` server with `detach=true` breaks
various `tt.setup_child_nvim` tests.

Solution:
Make this behavior opt-in with an env var, temporarily.
This commit is contained in:
Justin M. Keyes
2025-02-10 11:55:08 +01:00
parent 69abeaad1d
commit a1906c23dd
3 changed files with 53 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nvim/event/proc.c
View File

@@ -438,9 +438,9 @@ static void on_proc_exit(Proc *proc)
ILOG("child exited: pid=%d status=%d" PRIu64, proc->pid, proc->status);
// XXX: This assumes the TUI never spawns any other processes...?
// if (ui_client_channel_id) {
// exit_on_closed_chan(proc->status);
// }
if (ui_client_channel_id) {
exit_on_closed_chan(proc->status);
}
// Process has terminated, but there could still be data to be read from the
// OS. We are still in the libuv loop, so we cannot call code that polls for

3
src/nvim/ui_client.c
View File

@@ -62,7 +62,8 @@ uint64_t ui_client_start_server(int argc, char **argv)
on_err.fwd_err = true;
#ifdef MSWIN
bool detach = false; // TODO(justinmk): detach=true breaks `tt.setup_child_nvim` tests on Windows.
// TODO(justinmk): detach breaks `tt.setup_child_nvim` tests on Windows?
bool detach = os_env_exists("__NVIM_DETACH");
#else
bool detach = true;
#endif