From a62fb57e58bef7e7a4ba9d46a9e55983ca4ad945 Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Wed, 24 Sep 2025 11:41:43 +0800 Subject: [PATCH] test: don't call clear() in both before_each() and after_each() (#35901) --- test/functional/lua/glob_spec.lua | 1 - test/functional/lua/pos_spec.lua | 1 - test/functional/lua/range_spec.lua | 1 - test/functional/lua/snippet_spec.lua | 1 - test/functional/plugin/lsp/codelens_spec.lua | 1 - test/functional/plugin/lsp/completion_spec.lua | 4 ---- test/functional/plugin/lsp/diagnostic_spec.lua | 4 ---- test/functional/plugin/lsp/snippet_spec.lua | 1 - 8 files changed, 14 deletions(-) diff --git a/test/functional/lua/glob_spec.lua b/test/functional/lua/glob_spec.lua index a85fa3c309..c3d285c310 100644 --- a/test/functional/lua/glob_spec.lua +++ b/test/functional/lua/glob_spec.lua @@ -5,7 +5,6 @@ local eq = t.eq describe('glob', function() before_each(n.clear) - after_each(n.clear) local match = function(pattern, str) return n.exec_lua(function() diff --git a/test/functional/lua/pos_spec.lua b/test/functional/lua/pos_spec.lua index c9d33b449c..4102c8f536 100644 --- a/test/functional/lua/pos_spec.lua +++ b/test/functional/lua/pos_spec.lua @@ -9,7 +9,6 @@ local insert = n.insert describe('vim.pos', function() before_each(clear) - after_each(clear) it('creates a position with or without optional fields', function() local pos = exec_lua(function() diff --git a/test/functional/lua/range_spec.lua b/test/functional/lua/range_spec.lua index b211b2dc97..26d66f0684 100644 --- a/test/functional/lua/range_spec.lua +++ b/test/functional/lua/range_spec.lua @@ -9,7 +9,6 @@ local insert = n.insert describe('vim.range', function() before_each(clear) - after_each(clear) it('creates a range with or without optional fields', function() local range = exec_lua(function() diff --git a/test/functional/lua/snippet_spec.lua b/test/functional/lua/snippet_spec.lua index 2fdc71b316..f8dae42088 100644 --- a/test/functional/lua/snippet_spec.lua +++ b/test/functional/lua/snippet_spec.lua @@ -33,7 +33,6 @@ describe('vim.snippet', function() set_snippet_jump(-1, '') end) end) - after_each(clear) --- @param snippet string[] --- @param expected string[] diff --git a/test/functional/plugin/lsp/codelens_spec.lua b/test/functional/plugin/lsp/codelens_spec.lua index 20ef1cb49e..63c14419ad 100644 --- a/test/functional/plugin/lsp/codelens_spec.lua +++ b/test/functional/plugin/lsp/codelens_spec.lua @@ -9,7 +9,6 @@ describe('vim.lsp.codelens', function() n.clear() exec_lua('require("vim.lsp")') end) - after_each(n.clear) it('on_codelens_stores_and_displays_lenses', function() local fake_uri = 'file:///fake/uri' diff --git a/test/functional/plugin/lsp/completion_spec.lua b/test/functional/plugin/lsp/completion_spec.lua index 6570bbb95c..bb06e40500 100644 --- a/test/functional/plugin/lsp/completion_spec.lua +++ b/test/functional/plugin/lsp/completion_spec.lua @@ -863,8 +863,6 @@ describe('vim.lsp.completion: protocol', function() end) end) - after_each(clear) - local function assert_matches(fn) retry(nil, nil, function() fn(exec_lua('return _G.capture.matches')) @@ -1262,8 +1260,6 @@ describe('vim.lsp.completion: integration', function() end) end) - after_each(clear) - it('puts cursor at the end of completed word', function() local completion_list = { isIncomplete = false, diff --git a/test/functional/plugin/lsp/diagnostic_spec.lua b/test/functional/plugin/lsp/diagnostic_spec.lua index 72d1dfebab..b946caa142 100644 --- a/test/functional/plugin/lsp/diagnostic_spec.lua +++ b/test/functional/plugin/lsp/diagnostic_spec.lua @@ -115,10 +115,6 @@ describe('vim.lsp.diagnostic', function() end) end) - after_each(function() - clear() - end) - describe('vim.lsp.diagnostic.on_publish_diagnostics', function() it('correctly handles UTF-16 offsets', function() local line = 'All 💼 and no 🎉 makes Jack a dull 👦' diff --git a/test/functional/plugin/lsp/snippet_spec.lua b/test/functional/plugin/lsp/snippet_spec.lua index e60c36cd23..4cba151d3b 100644 --- a/test/functional/plugin/lsp/snippet_spec.lua +++ b/test/functional/plugin/lsp/snippet_spec.lua @@ -9,7 +9,6 @@ local exec_lua = n.exec_lua describe('vim.lsp._snippet_grammar', function() before_each(n.clear) - after_each(n.clear) local parse = function(...) local res = exec_lua('return require("vim.lsp._snippet_grammar").parse(...)', ...)