mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-03-30 20:32:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coverity/530026,530028): free resources on early exit in nlua_exec_file #33502

Browse Source 
Problem: The stdin reading path does not close `stdin_dup` or free `sb`
upon early exit.

Solution: Free the resources before returning false.
This commit is contained in:
Nathaniel Poppe
2025-04-21 15:43:38 +00:00
committed by GitHub
parent 986b92eb07
commit ab72799841
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/lua/executor.c
View File

@@ -1819,10 +1819,14 @@ bool nlua_exec_file(const char *path)
// Read all input from stdin, unless interrupted (ctrl-c).
while (true) {
if (got_int) { // User canceled.
file_close(&stdin_dup, false);
kv_destroy(sb);
return false;
}
ptrdiff_t read_size = file_read(&stdin_dup, IObuff, 64);
if (read_size < 0) { // Error.
file_close(&stdin_dup, false);
kv_destroy(sb);
return false;
}
if (read_size > 0) {