mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-27 21:48:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

channels: delay free so that libuv can cleanup handles

Browse Source 
add test for a crash this caused
This commit is contained in:
Björn Linse
2018-01-07 10:16:39 +01:00
parent 2cbeb7ca56
commit aea079a25d
2 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/nvim/channel.c
View File

@@ -245,7 +245,8 @@ void channel_incref(Channel *channel)
void channel_decref(Channel *channel)
{
if (!(--channel->refcount)) {
multiqueue_put(main_loop.fast_events, free_channel_event, 1, channel);
// delay free, so that libuv is done with the handles
multiqueue_put(main_loop.events, free_channel_event, 1, channel);
}
}
@@ -286,12 +287,15 @@ static void channel_destroy_early(Channel *chan)
if ((chan->id != --next_chan_id)) {
abort();
}
pmap_del(uint64_t)(channels, chan->id);
chan->id = 0;
if ((--chan->refcount != 0)) {
abort();
}
free_channel_event((void **)&chan);
// uv will keep a reference to handles until next loop tick, so delay free
multiqueue_put(main_loop.events, free_channel_event, 1, chan);
}