vim-patch:9.1.0934: hard to view an existing buffer in the preview window (#31605)

Problem:  hard to view an existing buffer in the preview window
Solution: add the :pbuffer command (Yinzuo Jiang)

Similar as `:pedit` and `:buffer` command. `:pbuffer` edits buffer [N]
from the buffer list in the preview window.

`:pbuffer` can also open special buffer, for example terminal buffer.

closes: vim/vim#16222

a2a2fe841e

Cherry-pick Test_popup_and_previewwindow_dump() changes from patch
9.0.0625.
Cherry-pick Run_noroom_for_newwindow_test() changes from patches
8.2.0432 and 9.0.0363.

Co-authored-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
This commit is contained in:
zeertzjq
2024-12-17 11:34:30 +08:00
committed by GitHub
parent 15153c4cd5
commit b03e790cdd
10 changed files with 216 additions and 37 deletions

View File

@@ -1946,6 +1946,12 @@ M.cmds = {
addr_type = 'ADDR_NONE',
func = 'ex_packloadall',
},
{
command = 'pbuffer',
flags = bit.bor(BANG, RANGE, BUFNAME, BUFUNL, COUNT, EXTRA, CMDARG, TRLBAR),
addr_type = 'ADDR_BUFFERS',
func = 'ex_pbuffer',
},
{
command = 'pclose',
flags = bit.bor(BANG, TRLBAR),

View File

@@ -4501,6 +4501,12 @@ static void ex_bunload(exarg_T *eap)
/// :[N]buffer [N] to buffer N
/// :[N]sbuffer [N] to buffer N
static void ex_buffer(exarg_T *eap)
{
do_exbuffer(eap);
}
/// ":buffer" command and alike.
static void do_exbuffer(exarg_T *eap)
{
if (*eap->arg) {
eap->errmsg = ex_errmsg(e_trailing_arg, eap->arg);
@@ -7002,14 +7008,35 @@ static void ex_ptag(exarg_T *eap)
static void ex_pedit(exarg_T *eap)
{
win_T *curwin_save = curwin;
// Open the preview window or popup and make it the current window.
g_do_tagpreview = (int)p_pvh;
prepare_tagpreview(true);
prepare_preview_window();
// Edit the file.
do_exedit(eap, NULL);
back_to_current_window(curwin_save);
}
/// ":pbuffer"
static void ex_pbuffer(exarg_T *eap)
{
win_T *curwin_save = curwin;
prepare_preview_window();
// Go to the buffer.
do_exbuffer(eap);
back_to_current_window(curwin_save);
}
static void prepare_preview_window(void)
{
// Open the preview window or popup and make it the current window.
g_do_tagpreview = (int)p_pvh;
prepare_tagpreview(true);
}
static void back_to_current_window(win_T *curwin_save)
{
if (curwin != curwin_save && win_valid(curwin_save)) {
// Return cursor to where we were
validate_cursor(curwin);