From 00acd1db228c29d35d6b85f66303646ce1127190 Mon Sep 17 00:00:00 2001 From: Eamon Burns Date: Wed, 1 Apr 2026 11:17:53 -0700 Subject: [PATCH 1/2] fix(build.zig): remove runtime dependency on Windows SDK Co-Authored-By: ntdiary <2471314@gmail.com> --- build.zig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/build.zig b/build.zig index 68115ed032..8fa7590ebb 100644 --- a/build.zig +++ b/build.zig @@ -102,9 +102,12 @@ pub fn build(b: *std.Build) !void { } } if (!system_integration_options.uv) { - if (b.lazyDependency("libuv", .{ .target = target, .optimize = optimize })) |dep| { + // NOTE: libuv on Windows depends on Windows SDK when compiled with .Debug mode + // https://github.com/neovim/neovim/issues/36889 + const optimize_uv = if (optimize == .Debug and target.result.os.tag == .windows) .ReleaseSafe else optimize; + if (b.lazyDependency("libuv", .{ .target = target, .optimize = optimize_uv })) |dep| { libuv = dep.artifact("uv"); - libluv = try build_lua.build_libluv(b, target, optimize, lua, libuv.?, use_luajit); + libluv = try build_lua.build_libluv(b, target, optimize_uv, lua, libuv.?, use_luajit); libluv_host = if (cross_compiling) libluv_host: { const libuv_dep_host = b.lazyDependency("libuv", .{ From b34cd44ae663d3b191b44a6a1f0171250b3dd821 Mon Sep 17 00:00:00 2001 From: Eamon Burns Date: Mon, 13 Apr 2026 16:03:30 -0700 Subject: [PATCH 2/2] fix(build.zig): call `build_libluv` with standard optimize mode --- build.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.zig b/build.zig index 8fa7590ebb..4ded79632d 100644 --- a/build.zig +++ b/build.zig @@ -107,7 +107,7 @@ pub fn build(b: *std.Build) !void { const optimize_uv = if (optimize == .Debug and target.result.os.tag == .windows) .ReleaseSafe else optimize; if (b.lazyDependency("libuv", .{ .target = target, .optimize = optimize_uv })) |dep| { libuv = dep.artifact("uv"); - libluv = try build_lua.build_libluv(b, target, optimize_uv, lua, libuv.?, use_luajit); + libluv = try build_lua.build_libluv(b, target, optimize, lua, libuv.?, use_luajit); libluv_host = if (cross_compiling) libluv_host: { const libuv_dep_host = b.lazyDependency("libuv", .{