mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-16 08:18:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

coverity/13969: handle u_save() failure

Browse Source 
Looking at the implementation of u_save suggests that its failure is
a normal and expected situation (e.g. if undo isn't allowed for some
reason, it will fail). Also (most of) the other calls to u_save() in
do_put() return early.
This commit is contained in:
Nick Neisen
2018-05-16 19:17:11 -06:00
committed by Justin M. Keyes
parent 2aa308c685
commit b44b533ada
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/nvim/ops.c
View File

@@ -2724,7 +2724,9 @@ void do_put(int regname, yankreg_T *reg, int dir, long count, int flags)
// So the 'u' command restores cursor position after ".p, save the cursor // So the 'u' command restores cursor position after ".p, save the cursor
// position now (though not saving any text). // position now (though not saving any text).
if (command_start_char == 'a') { if (command_start_char == 'a') {
u_save(curwin->w_cursor.lnum, curwin->w_cursor.lnum + 1); if (u_save(curwin->w_cursor.lnum, curwin->w_cursor.lnum + 1) == FAIL) {
return;
}
} }
return; return;
} }
@@ -2742,7 +2744,6 @@ void do_put(int regname, yankreg_T *reg, int dir, long count, int flags)
// Autocommands may be executed when saving lines for undo, which may make // Autocommands may be executed when saving lines for undo, which may make
// y_array invalid. Start undo now to avoid that. // y_array invalid. Start undo now to avoid that.
if (u_save(curwin->w_cursor.lnum, curwin->w_cursor.lnum + 1) == FAIL) { if (u_save(curwin->w_cursor.lnum, curwin->w_cursor.lnum + 1) == FAIL) {
ELOG("Failed to save undo information");
return; return;
} }
} }