mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-04-01 13:22:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(window): don't leak fold memory with style=minimal #38287

Browse Source 
Problem: discarding saved option values in the WinInfo of closed style=minimal
windows leaks memory.

Solution: also free the nested folds.
This commit is contained in:
Sean Dewar
2026-03-14 09:18:21 +00:00
committed by GitHub
parent ab05b58b88
commit b4e3461e3f
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/nvim/window.c
View File

@@ -5565,6 +5565,7 @@ void win_free(win_T *wp, tabpage_T *tp)
// Discard saved options if the style is minimal. // Discard saved options if the style is minimal.
if (wp->w_config.style == kWinStyleMinimal && wip_wp->wi_optset) { if (wp->w_config.style == kWinStyleMinimal && wip_wp->wi_optset) {
clear_winopt(&wip_wp->wi_opt); clear_winopt(&wip_wp->wi_opt);
deleteFoldRecurse(buf, &wip_wp->wi_folds);
wip_wp->wi_optset = false; wip_wp->wi_optset = false;
} }
// If there already is an entry with "wi_win" set to NULL, only // If there already is an entry with "wi_win" set to NULL, only

6
test/functional/api/window_spec.lua
View File

@@ -3650,5 +3650,11 @@ describe('API/win', function()
eq(1, eval('&number')) eq(1, eval('&number'))
eq(1, eval('&rightleft')) -- unrelated option unaffected eq(1, eval('&rightleft')) -- unrelated option unaffected
end) end)
it('minimal style does not leak WinInfo fold memory', function()
feed('zfG')
api.nvim_open_win(0, true, { split = 'below', style = 'minimal' })
command('quit')
end)
end) end)
end) end)