mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 11:28:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.1846: [security] crash in fullcommand

Browse Source 
Problem:  crash in fullcommand
Solution: Check for typeval correctly

4c6fe2e2ea

Co-authored-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq
2023-09-03 09:12:44 +08:00
parent 272c4fba83
commit b55010a539
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/ex_docmd.c
View File

@@ -3136,7 +3136,7 @@ int cmd_exists(const char *const name)
/// "fullcommand" function /// "fullcommand" function
void f_fullcommand(typval_T *argvars, typval_T *rettv, EvalFuncData fptr) void f_fullcommand(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
{ {
char *name = argvars[0].vval.v_string; char *name = (char *)tv_get_string(&argvars[0]);
rettv->v_type = VAR_STRING; rettv->v_type = VAR_STRING;
rettv->vval.v_string = NULL; rettv->vval.v_string = NULL;

5
test/old/testdir/test_functions.vim
View File

@@ -3273,4 +3273,9 @@ func Test_string_reverse()
let &encoding = save_enc let &encoding = save_enc
endfunc endfunc
func Test_fullcommand()
" this used to crash vim
call assert_equal('', fullcommand(10))
endfunc
" vim: shiftwidth=2 sts=2 expandtab " vim: shiftwidth=2 sts=2 expandtab