From b56f7c6edd339ab8be32738f1ecb0d7056b7ab9c Mon Sep 17 00:00:00 2001
From: Yi Ming <ofseed@foxmail.com>
Date: Tue, 5 May 2026 20:35:35 +0800
Subject: [PATCH] fix(diagnostic): status() respects config.signs #39525

Problem:
`diagnostic.status` only follows the `config.status.format` setting to determine how to display diagnostic signs. However, `signs` can actually also be configured via `config.signs.text`.

Solution:
If the user has set symbols via `config.status.format`, let that determine the content of `signs`; otherwise, use `config.signs.text` for display.

TODO: drop support `type(config.status.format) == 'table'`; users should just configure `config.signs.text` directly.
---
 runtime/doc/diagnostic.txt     |  6 +++---
 runtime/lua/vim/diagnostic.lua | 20 +++++++++++++-------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/runtime/doc/diagnostic.txt b/runtime/doc/diagnostic.txt
index d75dbfcad6..0a2e8a549a 100644
--- a/runtime/doc/diagnostic.txt
+++ b/runtime/doc/diagnostic.txt
@@ -661,9 +661,9 @@ Lua module: vim.diagnostic                                    *diagnostic-api*
                      |diagnostic-severity|
       • {text}?      (`table<vim.diagnostic.Severity,string>`) A table mapping
                      |diagnostic-severity| to the sign text to display in the
-                     sign column. The default is to use `"E"`, `"W"`, `"I"`,
-                     and `"H"` for errors, warnings, information, and hints,
-                     respectively. Example: >lua
+                     sign column and statusline. The default is to use `"E"`,
+                     `"W"`, `"I"`, and `"H"` for errors, warnings,
+                     information, and hints, respectively. Example: >lua
                          vim.diagnostic.config({
                            signs = { text = { [vim.diagnostic.severity.ERROR] = 'E', ... } }
                          })
diff --git a/runtime/lua/vim/diagnostic.lua b/runtime/lua/vim/diagnostic.lua
index c73cb86136..5b804a8736 100644
--- a/runtime/lua/vim/diagnostic.lua
+++ b/runtime/lua/vim/diagnostic.lua
@@ -300,8 +300,8 @@ local M = vim._defer_require('vim.diagnostic', {
 --- @field priority? integer
 ---
 --- A table mapping |diagnostic-severity| to the sign text to display in the
---- sign column. The default is to use `"E"`, `"W"`, `"I"`, and `"H"` for errors,
---- warnings, information, and hints, respectively. Example:
+--- sign column and statusline. The default is to use `"E"`, `"W"`, `"I"`, and `"H"`
+--- for errors, warnings, information, and hints, respectively. Example:
 --- ```lua
 --- vim.diagnostic.config({
 ---   signs = { text = { [vim.diagnostic.severity.ERROR] = 'E', ... } }
@@ -1121,18 +1121,24 @@ function M.status(buf)
   vim.validate('config.format', config.format, { 'table', 'function' }, true)
 
   local counts = M.count(buf)
-  local format = config.format or default_status_signs
+  local format = config.format
   local result_str --- @type string
-  if type(format) == 'table' then
-    local signs = vim.tbl_extend('keep', format, default_status_signs)
+  if type(format) == 'function' then
+    result_str = format(counts)
+  else
+    local signs ---@type table<vim.diagnostic.Severity, string>
+    if type(format) == 'table' then
+      signs = format
+    else
+      signs = M._config.get_resolved_options(vim.diagnostic.config(), nil, buf).signs.text
+        or default_status_signs
+    end
     result_str = vim
       .iter(pairs(counts))
       :map(function(level, value)
         return ('%%#%s#%s:%s'):format(status_hl_map[level], signs[level], value)
       end)
       :join(' ')
-  else
-    result_str = format(counts)
   end
 
   if result_str:len() > 0 then