mirror of
https://github.com/neovim/neovim.git
synced 2025-10-21 09:12:07 +00:00
lsp: Accept text document edits with version zero
There were a couple of reports of "Buffer X newer than edits" problems. We first assumed that it is incorrect for a server to send 0 as a version - and stated that they should send a `null` instead, given that in the specification the `textDocument` of a `TextDocumentEdit` is a `OptionalVersionedTextDocumentIdentifier`. But it turns out that this was a change in 3.16, and in 3.15 and earlier versions of the specification it was a `VersionedTextDocumentIdentifier` and language servers didn't have a better option than sending `0` if they don't keep track of the version numbers. So this changes the version check to always accept `0` values. See - https://github.com/neovim/neovim/issues/12970 - https://github.com/neovim/neovim/issues/14256 - https://github.com/haskell/haskell-language-server/pull/1727
This commit is contained in:
@@ -470,6 +470,8 @@ function M.apply_text_document_edit(text_document_edit, index)
|
||||
-- `VersionedTextDocumentIdentifier`s version may be null
|
||||
-- https://microsoft.github.io/language-server-protocol/specification#versionedTextDocumentIdentifier
|
||||
if should_check_version and (text_document.version
|
||||
and text_document.version ~= vim.NIL
|
||||
and text_document.version > 0
|
||||
and M.buf_versions[bufnr]
|
||||
and M.buf_versions[bufnr] > text_document.version) then
|
||||
print("Buffer ", text_document.uri, " newer than edits.")
|
||||
|
Reference in New Issue
Block a user