vim-patch:8.0.0355: using uninitialized memory when 'isfname' is empty (#8493)

Problem:    Using uninitialized memory when 'isfname' is empty.
Solution:   Don't call getpwnam() without an argument. (Dominique Pelle,
            closes vim/vim#1464)
187a4f2814
This commit is contained in:
Jan Edmund Lazo
2018-06-08 02:10:38 -04:00
committed by Justin M. Keyes
parent 4871f26c22
commit be68f218ff
3 changed files with 17 additions and 9 deletions

View File

@@ -1097,17 +1097,18 @@ static bool has_env_var(char_u *p)
}
#ifdef SPECIAL_WILDCHAR
/*
* Return TRUE if "p" contains a special wildcard character.
* Allowing for escaping.
*/
// Return TRUE if "p" contains a special wildcard character, one that Vim
// cannot expand, requires using a shell.
static bool has_special_wildchar(char_u *p)
{
for (; *p; mb_ptr_adv(p)) {
if (*p == '\\' && p[1] != NUL)
++p;
else if (vim_strchr((char_u *)SPECIAL_WILDCHAR, *p) != NULL)
// Allow for escaping
if (*p == '\\' && p[1] != NUL) {
p++;
} else if (vim_strchr((char_u *)SPECIAL_WILDCHAR, *p) != NULL) {
return true;
}
}
return false;
}
@@ -2033,7 +2034,7 @@ int expand_wildcards(int num_pat, char_u **pat, int *num_files, char_u ***files,
break;
}
if (match_file_list(p_wig, (*files)[i], ffname)) {
// remove this matching files from the list
// remove this matching file from the list
xfree((*files)[i]);
for (j = i; j + 1 < *num_files; j++) {
(*files)[j] = (*files)[j + 1];