From c489b5a3e3e72abda731dd3768cf1d8b98f7264e Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Tue, 29 Apr 2025 09:44:54 +0800 Subject: [PATCH] test(lua/secure_spec): avoid magic number (#33700) Avoid magic number in skipping condition by moving the expected message to a variable. --- test/functional/lua/secure_spec.lua | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/functional/lua/secure_spec.lua b/test/functional/lua/secure_spec.lua index db83787588..912d97a3b5 100644 --- a/test/functional/lua/secure_spec.lua +++ b/test/functional/lua/secure_spec.lua @@ -47,7 +47,8 @@ describe('vim.secure', function() }) local cwd = fn.getcwd() - if #cwd + 23 > 500 then + local msg = cwd .. pathsep .. 'Xfile is not trusted.' + if #msg >= screen._width then pending('path too long') return end @@ -59,7 +60,7 @@ describe('vim.secure', function() {1:~{MATCH: +}}|*3 {2:{MATCH: +}}| :lua vim.secure.read('Xfile'){MATCH: +}| - {3:]] .. cwd .. pathsep .. [[Xfile is not trusted.}{MATCH: +}| + {3:]] .. msg .. [[}{MATCH: +}| {3:[i]gnore, (v)iew, (d)eny, (a)llow: }^{MATCH: +}| ]]) feed('d') @@ -81,7 +82,7 @@ describe('vim.secure', function() {1:~{MATCH: +}}|*3 {2:{MATCH: +}}| :lua vim.secure.read('Xfile'){MATCH: +}| - {3:]] .. cwd .. pathsep .. [[Xfile is not trusted.}{MATCH: +}| + {3:]] .. msg .. [[}{MATCH: +}| {3:[i]gnore, (v)iew, (d)eny, (a)llow: }^{MATCH: +}| ]]) feed('a') @@ -104,7 +105,7 @@ describe('vim.secure', function() {1:~{MATCH: +}}|*3 {2:{MATCH: +}}| :lua vim.secure.read('Xfile'){MATCH: +}| - {3:]] .. cwd .. pathsep .. [[Xfile is not trusted.}{MATCH: +}| + {3:]] .. msg .. [[}{MATCH: +}| {3:[i]gnore, (v)iew, (d)eny, (a)llow: }^{MATCH: +}| ]]) feed('i') @@ -123,7 +124,7 @@ describe('vim.secure', function() {1:~{MATCH: +}}|*3 {2:{MATCH: +}}| :lua vim.secure.read('Xfile'){MATCH: +}| - {3:]] .. cwd .. pathsep .. [[Xfile is not trusted.}{MATCH: +}| + {3:]] .. msg .. [[}{MATCH: +}| {3:[i]gnore, (v)iew, (d)eny, (a)llow: }^{MATCH: +}| ]]) feed('v')