mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-25 20:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

API: fix nvim_command_output buffer overflow (#10830)

Browse Source 
Fixes https://github.com/neovim/neovim/issues/10829.
This commit is contained in:
Abdelhakeem Osama
2019-08-22 11:07:54 +03:00
committed by Daniel Hahler
parent ed28668392
commit c6eb1f42be
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/api/vim.c
View File

@@ -364,7 +364,7 @@ String nvim_command_output(String command, Error *err)
}; };
// redir usually (except :echon) prepends a newline. // redir usually (except :echon) prepends a newline.
if (s.data[0] == '\n') { if (s.data[0] == '\n') {
memmove(s.data, s.data + 1, s.size); memmove(s.data, s.data + 1, s.size - 1);
s.data[s.size - 1] = '\0'; s.data[s.size - 1] = '\0';
s.size = s.size - 1; s.size = s.size - 1;
} }

5
test/functional/api/vim_spec.lua
View File

@@ -178,6 +178,11 @@ describe('API', function()
-- Verify NO hit-enter prompt. -- Verify NO hit-enter prompt.
eq({mode='n', blocking=false}, nvim("get_mode")) eq({mode='n', blocking=false}, nvim("get_mode"))
end) end)
it('Does not cause heap buffer overflow with large output', function()
eq(eval('string(range(1000000))'),
nvim('command_output', 'echo range(1000000)'))
end)
end) end)
describe('nvim_eval', function() describe('nvim_eval', function()