fix(decor): enable decoration provider in on_start #33337

Problem:  An on_win-disabled decoration provider is left disabled for
          the on_buf callback during the next redraw (if the provider
          does not subscribe to on_end).

Solution: Move re-activation of the provider from after the on_end
          callback to before the on_start callback.
This commit is contained in:
luukvbaal
2025-04-07 12:58:18 +02:00
committed by GitHub
parent cf59631f65
commit ca16b54c86
2 changed files with 22 additions and 1 deletions

View File

@@ -118,6 +118,8 @@ void decor_providers_start(void)
ADD_C(args, INTEGER_OBJ((int)display_tick));
bool active = decor_provider_invoke((int)i, "start", p->redraw_start, args, true);
kv_A(decor_providers, i).state = active ? kDecorProviderActive : kDecorProviderRedrawDisabled;
} else if (p->state != kDecorProviderDisabled) {
kv_A(decor_providers, i).state = kDecorProviderActive;
}
}
}
@@ -220,7 +222,6 @@ void decor_providers_invoke_end(void)
MAXSIZE_TEMP_ARRAY(args, 1);
ADD_C(args, INTEGER_OBJ((int)display_tick));
decor_provider_invoke((int)i, "end", p->redraw_end, args, true);
kv_A(decor_providers, i).state = kDecorProviderActive;
}
}
decor_check_to_be_deleted();