vim-patch:7.4.323 #967

Problem:    Substitute() with zero width pattern breaks multi-byte character.
Solution:   Take multi-byte character size into account. (Yukihiro Nakadaira)

https://code.google.com/p/vim/source/detail?r=238f5027830cad22e17a970483af9b160869cdf3

src/nvim/eval.c

@@ -18996,8 +18996,10 @@ char_u *do_string_sub(char_u *str, char_u *pat, char_u *sub, char_u *flags)
       if (regmatch.startp[0] == regmatch.endp[0]) {
         if (zero_width == regmatch.startp[0]) {
           /* avoid getting stuck on a match with an empty string */
-          *((char_u *)ga.ga_data + ga.ga_len) = *tail++;
-          ++ga.ga_len;
+          int i = MB_PTR2LEN(tail);
+          memmove((char_u *)ga.ga_data + ga.ga_len, tail, (size_t)i);
+          ga.ga_len += i;
+          tail += i;
           continue;
         }
         zero_width = regmatch.startp[0];

src/nvim/testdir/test69.in

@@ -179,6 +179,13 @@ ENDTEST
 byteidx
 byteidxcomp
 
+STARTTEST
+/^substitute
+:let y = substitute('１２３', '\zs', 'a', 'g') | put =y
+ENDTEST
+
+substitute
+
 STARTTEST
 :g/^STARTTEST/.,/^ENDTEST/d
 :1;/^Results/,$wq! test.out

src/nvim/testdir/test69.ok

@@ -160,3 +160,7 @@ byteidxcomp
 [0, 1, 3, 4, -1]
 [0, 1, 2, 4, 5, -1]
 
+
+substitute
+a１a２a３a
+

src/nvim/version.c

@@ -226,7 +226,7 @@ static int included_patches[] = {
   //326,
   //325,
   //324,
-  //323,
+  323,
   //322,
   //321,
   //320,