mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-01 23:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.2.3743: ":sign" can add a highlight group without a name

Browse Source 
Problem:    ":sign" can add a highlight group without a name.
Solution:   Give an error if the group name is missing. (closes vim/vim#9280)
5e18ccc60b
This commit is contained in:
James McCoy
2021-12-05 21:39:37 -05:00
parent e8f9262125
commit d0b3efb7db
3 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/nvim/sign.c
View File

@@ -1132,6 +1132,15 @@ linenr_T sign_jump(int sign_id, char_u *sign_group, buf_T *buf)
return lnum;
}
static int check_empty_group(size_t len, char *name)
{
if (len == 0) {
semsg(_(e_group_name_missing_for_str), name);
return FAIL;
}
return OK;
}
/// ":sign define {name} ..." command
static void sign_define_cmd(char_u *sign_name, char_u *cmdline)
{
@@ -1160,15 +1169,31 @@ static void sign_define_cmd(char_u *sign_name, char_u *cmdline)
text = vim_strnsave(arg, (size_t)(p - arg));
} else if (STRNCMP(arg, "linehl=", 7) == 0) {
arg += 7;
if (check_empty_group(p - arg, "linehl") == FAIL) {
failed = true;
break;
}
linehl = vim_strnsave(arg, (size_t)(p - arg));
} else if (STRNCMP(arg, "texthl=", 7) == 0) {
arg += 7;
if (check_empty_group(p - arg, "texthl") == FAIL) {
failed = true;
break;
}
texthl = vim_strnsave(arg, (size_t)(p - arg));
} else if (STRNCMP(arg, "culhl=", 6) == 0) {
arg += 6;
if (check_empty_group(p - arg, "culhl") == FAIL) {
failed = true;
break;
}
culhl = vim_strnsave(arg, (size_t)(p - arg));
} else if (STRNCMP(arg, "numhl=", 6) == 0) {
arg += 6;
if (check_empty_group(p - arg, "numhl") == FAIL) {
failed = true;
break;
}
numhl = vim_strnsave(arg, (size_t)(p - arg));
} else {
semsg(_(e_invarg2), arg);