mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 11:28:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.0804: crash when trying to divide a number by -1

Browse Source 
Problem:    Crash when trying to divice the largest negative number by -1.
Solution:   Handle this case specifically.
cdef1cefa2
This commit is contained in:
zeertzjq
2022-10-20 22:05:51 +08:00
parent be0f284ae1
commit d1484b58ae
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/eval.c
View File

@@ -330,6 +330,10 @@ varnumber_T num_divide(varnumber_T n1, varnumber_T n2)
} else { } else {
result = VARNUMBER_MAX; result = VARNUMBER_MAX;
} }
} else if (n1 == VARNUMBER_MIN && n2 == -1) {
// specific case: trying to do VARNUMBAR_MIN / -1 results in a positive
// number that doesn't fit in varnumber_T and causes an FPE
result = VARNUMBER_MAX;
} else { } else {
result = n1 / n2; result = n1 / n2;
} }

6
src/nvim/testdir/test_expr.vim
View File

@@ -602,6 +602,12 @@ func Test_eval_after_if()
call assert_equal('b', s:val) call assert_equal('b', s:val)
endfunc endfunc
func Test_divide_by_zero()
" only tests that this doesn't crash, the result is not important
echo 0 / 0
echo 0 / 0 / -1
endfunc
" Test for command-line completion of expressions " Test for command-line completion of expressions
func Test_expr_completion() func Test_expr_completion()
CheckFeature cmdline_compl CheckFeature cmdline_compl