mirror of
https://github.com/neovim/neovim.git
synced 2025-10-08 02:46:31 +00:00
refactor: collapse statements in single assignments
Problem: Variables are often assigned multiple places in common patterns. Solution: Replace these common patterns with different patterns that reduce the number of assignments. Use `MAX` and `MIN`: ```c if (x < y) { x = y; } // --> x = MAX(x, y); ``` ```c if (x > y) { x = y; } // --> x = MIN(x, y); ``` Use ternary: ```c int a; if (cond) { a = b; } els { a = c; } // --> int a = cond ? b : c; ```
This commit is contained in:

committed by
Lewis Russell

parent
1b5a394ffd
commit
d1bd3d643e
@@ -886,9 +886,7 @@ static int get_rightmost_vcol(win_T *wp, const int *color_cols)
|
||||
if (color_cols) {
|
||||
// determine rightmost colorcolumn to possibly draw
|
||||
for (int i = 0; color_cols[i] >= 0; i++) {
|
||||
if (ret < color_cols[i]) {
|
||||
ret = color_cols[i];
|
||||
}
|
||||
ret = MAX(ret, color_cols[i]);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -2560,9 +2558,7 @@ int win_line(win_T *wp, linenr_T lnum, int startrow, int endrow, int col_rows, s
|
||||
// Highlight 'cursorcolumn' & 'colorcolumn' past end of the line.
|
||||
|
||||
// check if line ends before left margin
|
||||
if (wlv.vcol < start_col + wlv.col - win_col_off(wp)) {
|
||||
wlv.vcol = start_col + wlv.col - win_col_off(wp);
|
||||
}
|
||||
wlv.vcol = MAX(wlv.vcol, start_col + wlv.col - win_col_off(wp));
|
||||
// Get rid of the boguscols now, we want to draw until the right
|
||||
// edge for 'cursorcolumn'.
|
||||
wlv.col -= wlv.boguscols;
|
||||
|
Reference in New Issue
Block a user