mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-26 12:27:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): suppress ContentModified errors from UI (#16904)

Browse Source 
Fixes https://github.com/neovim/neovim/issues/16900

If clients receive a ContentModified error, it generally should not
show it in the UI for the end-user. Clients can resend the request if
they know how to do so.

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#implementationConsiderations
This commit is contained in:
Sam McCall
2022-01-04 18:28:13 +01:00
committed by GitHub
parent 3fd454bd4a
commit d6f0c9539c
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
runtime/lua/vim/lsp/handlers.lua
View File

@@ -439,14 +439,20 @@ for k, fn in pairs(M) do
}) })
if err then if err then
local client = vim.lsp.get_client_by_id(ctx.client_id)
local client_name = client and client.name or string.format("client_id=%d", ctx.client_id)
-- LSP spec: -- LSP spec:
-- interface ResponseError: -- interface ResponseError:
-- code: integer; -- code: integer;
-- message: string; -- message: string;
-- data?: string | number | boolean | array | object | null; -- data?: string | number | boolean | array | object | null;
return err_message(client_name .. ': ' .. tostring(err.code) .. ': ' .. err.message)
-- Per LSP, don't show ContentModified error to the user.
if err.code ~= protocol.ErrorCodes.ContentModified then
local client = vim.lsp.get_client_by_id(ctx.client_id)
local client_name = client and client.name or string.format("client_id=%d", ctx.client_id)
err_message(client_name .. ': ' .. tostring(err.code) .. ': ' .. err.message)
end
return
end end
return fn(err, result, ctx, config) return fn(err, result, ctx, config)