mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-08 20:38:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.1.0152: Coverity complains about ignoring return value

Browse Source 
Problem:  Coverity complains about ignoring return value of win_split()
          (after v9.1.150)
Solution: Check if win_split() failed, add winfixbuf.res to Makefile

af7ae81600

Co-authored-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq
2024-03-11 11:25:00 +08:00
parent 5931f2bc4a
commit d71791a11a
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/nvim/ex_cmds2.c
View File

@@ -457,8 +457,9 @@ void ex_listdo(exarg_T *eap)
} }
if (curwin->w_p_wfb) { if (curwin->w_p_wfb) {
// Split the window, which will be 'nowinfixbuf', and set curwin to that // Split the window, which will be 'nowinfixbuf', and set curwin to that
win_split(0, 0); if (win_split(0, 0) == FAIL) {
return; // error message already given
}
if (curwin->w_p_wfb) { if (curwin->w_p_wfb) {
// Autocommands set 'winfixbuf' or sent us to another window // Autocommands set 'winfixbuf' or sent us to another window
// with it set. Give up. // with it set. Give up.

11
test/old/testdir/test_winfixbuf.vim
View File

@@ -3248,4 +3248,15 @@ func Test_quickfix_changed_split_failed()
augroup! QfChanged augroup! QfChanged
endfunc endfunc
func Test_bufdo_splitwin_fails()
call s:reset_all_buffers()
let other = s:make_buffer_pairs()
" Make sure there is not enough room to
" split the winfixedbuf window
let &winheight=&lines
let &winminheight=&lines-2
call assert_fails(':bufdo echo 1', 'E36:')
set winminheight&vim winheight&vim
endfunc
" vim: shiftwidth=2 sts=2 expandtab " vim: shiftwidth=2 sts=2 expandtab