test: reorg #15698

Problem:
Subdirectories like "visual", "insert", "normal" encourage people to
separate *related* tests for no good reason.  Typically the _mode_ is
not the relevant topic of a test (and when it is, _then_ create
an appropriate describe() or it()).

Solution:
- Delete the various `test/functional/<mode>/` subdirectories, move
  their tests to more meaningful topics.
- Rename `…/normal/` to `…/editor/`.
  - Move or merge `…/visual/*` and `…/insert/*` tests into here where
    appropriate.
- Rename `…/eval/` to `…/vimscript/`.
  - Move `…/viml/*` into here also.

* test(reorg): insert/* => editor/mode_insert_spec.lua
* test(reorg): cmdline/* => editor/mode_cmdline_spec.lua
* test(reorg): eval core tests => eval_spec.lua

test/functional/vimscript/server_spec.lua

@@ -0,0 +1,156 @@
+local helpers = require('test.functional.helpers')(after_each)
+local eq, neq, eval = helpers.eq, helpers.neq, helpers.eval
+local command = helpers.command
+local clear, funcs, meths = helpers.clear, helpers.funcs, helpers.meths
+local iswin = helpers.iswin
+local ok = helpers.ok
+local matches = helpers.matches
+local pcall_err = helpers.pcall_err
+
+local function clear_serverlist()
+  for _, server in pairs(funcs.serverlist()) do
+    funcs.serverstop(server)
+  end
+end
+
+describe('server', function()
+  before_each(clear)
+
+  it('serverstart() sets $NVIM_LISTEN_ADDRESS on first invocation', function()
+    -- Unset $NVIM_LISTEN_ADDRESS
+    command('let $NVIM_LISTEN_ADDRESS = ""')
+
+    local s = eval('serverstart()')
+    assert(s ~= nil and s:len() > 0, "serverstart() returned empty")
+    eq(s, eval('$NVIM_LISTEN_ADDRESS'))
+    eq(1, eval("serverstop('"..s.."')"))
+    eq('', eval('$NVIM_LISTEN_ADDRESS'))
+  end)
+
+  it('sets new v:servername if $NVIM_LISTEN_ADDRESS is invalid', function()
+    clear({env={NVIM_LISTEN_ADDRESS='.'}})
+    eq('.', eval('$NVIM_LISTEN_ADDRESS'))
+    local servers = funcs.serverlist()
+    eq(1, #servers)
+    ok(string.len(servers[1]) > 4)  -- Like /tmp/nvim…/… or \\.\pipe\…
+  end)
+
+  it('sets v:servername at startup or if all servers were stopped',
+  function()
+    local initial_server = meths.get_vvar('servername')
+    assert(initial_server ~= nil and initial_server:len() > 0,
+           'v:servername was not initialized')
+
+    -- v:servername is readonly so we cannot unset it--but we can test that it
+    -- does not get set again thereafter.
+    local s = funcs.serverstart()
+    assert(s ~= nil and s:len() > 0, "serverstart() returned empty")
+    neq(initial_server, s)
+
+    -- serverstop() does _not_ modify v:servername...
+    eq(1, funcs.serverstop(s))
+    eq(initial_server, meths.get_vvar('servername'))
+
+    -- ...unless we stop _all_ servers.
+    eq(1, funcs.serverstop(funcs.serverlist()[1]))
+    eq('', meths.get_vvar('servername'))
+
+    -- v:servername will take the next available server.
+    local servername = (iswin() and [[\\.\pipe\Xtest-functional-server-pipe]]
+                                or 'Xtest-functional-server-socket')
+    funcs.serverstart(servername)
+    eq(servername, meths.get_vvar('servername'))
+  end)
+
+  it('serverstop() returns false for invalid input', function()
+    eq(0, eval("serverstop('')"))
+    eq(0, eval("serverstop('bogus-socket-name')"))
+  end)
+
+  it('parses endpoints correctly', function()
+    clear_serverlist()
+    eq({}, funcs.serverlist())
+
+    local s = funcs.serverstart('127.0.0.1:0')  -- assign random port
+    if #s > 0 then
+      assert(string.match(s, '127.0.0.1:%d+'))
+      eq(s, funcs.serverlist()[1])
+      clear_serverlist()
+    end
+
+    s = funcs.serverstart('127.0.0.1:')  -- assign random port
+    if #s > 0 then
+      assert(string.match(s, '127.0.0.1:%d+'))
+      eq(s, funcs.serverlist()[1])
+      clear_serverlist()
+    end
+
+    local expected = {}
+    local v4 = '127.0.0.1:12345'
+    local status, _ = pcall(funcs.serverstart, v4)
+    if status then
+      table.insert(expected, v4)
+      pcall(funcs.serverstart, v4)  -- exists already; ignore
+    end
+
+    local v6 = '::1:12345'
+    status, _ = pcall(funcs.serverstart, v6)
+    if status then
+      table.insert(expected, v6)
+      pcall(funcs.serverstart, v6)  -- exists already; ignore
+    end
+    eq(expected, funcs.serverlist())
+    clear_serverlist()
+
+    eq('Vim:Failed to start server: invalid argument',
+      pcall_err(funcs.serverstart, '127.0.0.1:65536'))  -- invalid port
+    eq({}, funcs.serverlist())
+  end)
+
+  it('serverlist() returns the list of servers', function()
+    -- There should already be at least one server.
+    local n = eval('len(serverlist())')
+
+    -- Add some servers.
+    local servs = (iswin()
+      and { [[\\.\pipe\Xtest-pipe0934]], [[\\.\pipe\Xtest-pipe4324]] }
+      or  { [[Xtest-pipe0934]], [[Xtest-pipe4324]] })
+    for _, s in ipairs(servs) do
+      eq(s, eval("serverstart('"..s.."')"))
+    end
+
+    local new_servs = eval('serverlist()')
+
+    -- Exactly #servs servers should be added.
+    eq(n + #servs, #new_servs)
+    -- The new servers should be at the end of the list.
+    for i = 1, #servs do
+      eq(servs[i], new_servs[i + n])
+      eq(1, eval("serverstop('"..servs[i].."')"))
+    end
+    -- After serverstop() the servers should NOT be in the list.
+    eq(n, eval('len(serverlist())'))
+  end)
+end)
+
+describe('startup --listen', function()
+  it('validates', function()
+    clear()
+
+    local cmd = { unpack(helpers.nvim_argv) }
+    table.insert(cmd, '--listen')
+    matches('nvim.*: Argument missing after: "%-%-listen"', funcs.system(cmd))
+
+    cmd = { unpack(helpers.nvim_argv) }
+    table.insert(cmd, '--listen2')
+    matches('nvim.*: Garbage after option argument: "%-%-listen2"', funcs.system(cmd))
+  end)
+
+  it('sets v:servername, overrides $NVIM_LISTEN_ADDRESS', function()
+    local addr = (iswin() and [[\\.\pipe\Xtest-listen-pipe]]
+                          or 'Xtest-listen-pipe')
+    clear({ env={ NVIM_LISTEN_ADDRESS='Xtest-env-pipe' },
+            args={ '--listen', addr } })
+    eq(addr, meths.get_vvar('servername'))
+  end)
+end)