mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-28 14:08:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api/command): fargs behavior when no arguments are passed (#19862)

Browse Source 
Problem: A command defined with `nargs="?"` returns `fargs={""}` to
a Lua callback when executed with no arguments, which is inconsistent
with how`nargs="*"` behaves.

Solution: Pass `fargs={}` for no argument with `nargs="?"` as well.
This commit is contained in:
Javier Lopez
2022-08-21 08:19:29 -05:00
committed by GitHub
parent 5928d5c2f1
commit dde90f0ca4
2 changed files with 91 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/nvim/lua/executor.c
View File

@@ -1940,8 +1940,13 @@ int nlua_do_ucmd(ucmd_T *cmd, exarg_T *eap, bool preview)
// Split args by unescaped whitespace |<f-args>| (nargs dependent)
if (cmd->uc_argt & EX_NOSPC) {
// Commands where nargs = 1 or "?" fargs is the same as args
lua_rawseti(lstate, -2, 1);
if ((cmd->uc_argt & EX_NEEDARG) || STRLEN(eap->arg)) {
// For commands where nargs is 1 or "?" and argument is passed, fargs = { args }
lua_rawseti(lstate, -2, 1);
} else {
// if nargs = "?" and no argument is passed, fargs = {}
lua_pop(lstate, 1); // Pop the reference of opts.args
}
} else if (eap->args == NULL) {
// For commands with more than one possible argument, split if argument list isn't available.
lua_pop(lstate, 1); // Pop the reference of opts.args