mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-02 07:58:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.2.0039: memory access error when "z=" has no suggestions

Browse Source 
Problem:    Memory access error when "z=" has no suggestions.
Solution:   Check for negative index.
569fea2c31
This commit is contained in:
Jan Edmund Lazo
2021-06-11 22:32:39 -04:00
parent f376e67a53
commit e78656875d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/spell.c
View File

@@ -5761,7 +5761,9 @@ cleanup_suggestions (
xfree(stp[i].st_word); xfree(stp[i].st_word);
} }
gap->ga_len = keep; gap->ga_len = keep;
return stp[keep - 1].st_score; if (keep >= 1) {
return stp[keep - 1].st_score;
}
} }
} }
return maxscore; return maxscore;

4
src/nvim/testdir/test_spell.vim
View File

@@ -285,9 +285,7 @@ func Test_spellsuggest_option_number()
\ .. "Type number and <Enter> or click with the mouse (q or empty cancels): ", a) \ .. "Type number and <Enter> or click with the mouse (q or empty cancels): ", a)
set spell spellsuggest=0 set spell spellsuggest=0
" FIXME: the following line is currently commented out as it triggers a call assert_equal("\nSorry, no suggestions", execute('norm z='))
" memory error detected in cleanup_suggestions() by asan or valgrind.
"call assert_equal("\nSorry, no suggestions", execute('norm z='))
" Unlike z=, function spellsuggest(...) should not be affected by the " Unlike z=, function spellsuggest(...) should not be affected by the
" max number of suggestions (2) set by the 'spellsuggest' option. " max number of suggestions (2) set by the 'spellsuggest' option.