mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-11-22 10:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix warnings: ex_eval.c: report_pending(): Np dereference: FP.

Browse Source 
Problem    : Dereference of null pointer @ 711.
Diagnostic : False positive.
Rationale  : Codepath producing error invokes this function with values
             `action=RPC_DISCARD, pending=CSTP_FINISH, value=NULL`.
             Now, for some reason, the analyzer is remembering that
             `value` is null, and that `action` is `RPC_DISCARD`, but
             it's not remembering that `pending` is `CSTP_FINISH`.
             Then, it's taking the wrong branch in the switch for
             `pending`. That path would never occur invocating the
             function with those values.
Resolution : Assert function precondition between `pending` and `value`.
             This is, let the compiler know that `value` being null
             implies `pending` not containing `CSTP_THROW`.
This commit is contained in:
Eliseo Martínez
2014-11-08 13:04:35 +01:00
parent 1575642b11
commit ea1f883b19
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/nvim/ex_eval.c
View File

@@ -9,8 +9,8 @@
/* /*
* ex_eval.c: functions for Ex command line for the +eval feature. * ex_eval.c: functions for Ex command line for the +eval feature.
*/ */
#include <assert.h>
#include <stdbool.h> #include <stdbool.h>
#include <inttypes.h> #include <inttypes.h>
#include "nvim/vim.h" #include "nvim/vim.h"
@@ -670,6 +670,7 @@ static void report_pending(int action, int pending, void *value)
char *s; char *s;
int save_msg_silent; int save_msg_silent;
assert(value || !(pending & CSTP_THROW));
switch (action) { switch (action) {
case RP_MAKE: case RP_MAKE: