Merge pull request #14771 from gpanders/colorscheme

fix: source syncolors.vim before startup scripts

runtime/syntax/syncolor.vim

@@ -25,6 +25,8 @@ else
   endif
 endif
 
+let did_syncolor = 1
+
 " Many terminals can only use six different colors (plus black and white).
 " Therefore the number of colors used is kept low. It doesn't look nice with
 " too many colors anyway.

runtime/syntax/synload.vim

@@ -14,10 +14,8 @@ endif
 " let others know that syntax has been switched on
 let syntax_on = 1
 
-" Set the default highlighting colors.  Use a color scheme if specified.
+" Set the default highlighting colors
-if exists("colors_name")
+if !exists("colors_name") && !exists("did_syncolor")
-  exe "colors " . colors_name
-else
   runtime! syntax/syncolor.vim
 endif
 

src/nvim/main.c

@@ -366,11 +366,19 @@ int main(int argc, char **argv)
   // Execute --cmd arguments.
   exe_pre_commands(&params);
 
+  // If using the runtime (-u is not NONE), enable syntax & filetype plugins.
+  bool enable_syntax =
+    (params.use_vimrc == NULL || !strequal(params.use_vimrc, "NONE"));
+
+  // Source syncolor.vim to set up default UI highlights
+  if (enable_syntax) {
+    source_runtime((char_u *)"syntax/syncolor.vim", DIP_ALL);
+  }
+
   // Source startup scripts.
   source_startup_scripts(&params);
 
-  // If using the runtime (-u is not NONE), enable syntax & filetype plugins.
+  if (enable_syntax) {
-  if (params.use_vimrc == NULL || !strequal(params.use_vimrc, "NONE")) {
     // Does ":filetype plugin indent on".
     filetype_maybe_enable();
     // Sources syntax/syntax.vim, which calls `:filetype on`.