mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-15 22:36:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory leak from double buffer initialization in read_stdin #35413

Browse Source 
Problem: When stdin follows files, set_curbuf() initializes buffer via
enter_buffer(), then open_buffer() initializes again, causing memory leaks.

Solution: Use readfile() directly for new buffers already initialized by
enter_buffer(), only call open_buffer() for original buffer case.
This commit is contained in:
glepnir
2025-08-23 05:50:30 +08:00
committed by GitHub
parent 586b1b2d9b
commit eeba0dc2ed
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/nvim/main.c
View File

@@ -1627,7 +1627,7 @@ static void read_stdin(void)
if (curbuf->b_ffname) { if (curbuf->b_ffname) {
// curbuf is already opened for a file, create a new buffer for stdin. #35269 // curbuf is already opened for a file, create a new buffer for stdin. #35269
buf_T *newbuf = buflist_new(NULL, NULL, 0, 0); buf_T *newbuf = buflist_new(NULL, NULL, 0, BLN_LISTED);
if (newbuf == NULL) { if (newbuf == NULL) {
semsg("Failed to create buffer for stdin"); semsg("Failed to create buffer for stdin");
return; return;
@@ -1636,11 +1636,13 @@ static void read_stdin(void)
// remember the current buffer so we can go back to it // remember the current buffer so we can go back to it
prev_buf = curbuf; prev_buf = curbuf;
set_curbuf(newbuf, 0, false); set_curbuf(newbuf, 0, false);
readfile(NULL, NULL, 0, 0, (linenr_T)MAXLNUM, NULL, READ_NEW + READ_STDIN, true);
} else {
set_buflisted(true);
// Create memfile and read from stdin.
open_buffer(true, NULL, 0);
} }
set_buflisted(true);
// Create memfile and read from stdin.
open_buffer(true, NULL, 0);
if (buf_is_empty(curbuf)) { if (buf_is_empty(curbuf)) {
// stdin was empty so we should wipe it (e.g. "echo file1 | xargs nvim"). #8561 // stdin was empty so we should wipe it (e.g. "echo file1 | xargs nvim"). #8561
// stdin buffer may be first or last ("echo foo | nvim file1 -"). #35269 // stdin buffer may be first or last ("echo foo | nvim file1 -"). #35269