From efed75f91638bc52a2a551683c2f7a1da4a1e3ea Mon Sep 17 00:00:00 2001 From: James McCoy Date: Thu, 6 May 2021 00:08:06 -0400 Subject: [PATCH] coverity/331377: os_fopen: Remove invalid iflags assert If the O_* flags were non-zero, then ORing the flags would always be true. However, the O_* flags aren't guaranteed to be non-zero, so the assert is invalid in the first place. --- src/nvim/os/fs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/nvim/os/fs.c b/src/nvim/os/fs.c index a3bef3389c..d0fa74a77f 100644 --- a/src/nvim/os/fs.c +++ b/src/nvim/os/fs.c @@ -471,8 +471,6 @@ FILE *os_fopen(const char *path, const char *flags) abort(); } } - // Per open(2) manpage. - assert((iflags|O_RDONLY) || (iflags|O_WRONLY) || (iflags|O_RDWR)); // Per fopen(3) manpage: default to 0666, it will be umask-adjusted. int fd = os_open(path, iflags, 0666); if (fd < 0) {