mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-08 19:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.1.0181: memory leak with trailing characters in skip expression

Browse Source 
Problem:    Memory leak with trailing characters in skip expression.
Solution:   Free the return value.
a43ebe9454
This commit is contained in:
Jan Edmund Lazo
2019-06-21 20:46:43 -04:00
parent 6eae28f090
commit f0d6695e7c
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/nvim/eval.c
View File

@@ -991,6 +991,7 @@ static int eval_expr_typval(const typval_T *expr, typval_T *argv,
return FAIL; return FAIL;
} }
if (*s != NUL) { // check for trailing chars after expr if (*s != NUL) { // check for trailing chars after expr
tv_clear(rettv);
emsgf(_(e_invexpr2), s); emsgf(_(e_invexpr2), s);
return FAIL; return FAIL;
} }

10
src/nvim/testdir/test_search.vim
View File

@@ -325,6 +325,16 @@ func Test_searchpair_skip()
bw! bw!
endfunc endfunc
func Test_searchpair_leak()
new
call setline(1, 'if one else another endif')
" The error in the skip expression caused memory to leak.
call assert_fails("call searchpair('\\<if\\>', '\\<else\\>', '\\<endif\\>', '', '\"foo\" 2')", 'E15:')
bwipe!
endfunc
func Test_searchc() func Test_searchc()
" These commands used to cause memory overflow in searchc(). " These commands used to cause memory overflow in searchc().
new new