From f91d416403e923ba9c89f663a6acca80f5ace4ad Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Sun, 21 Sep 2025 07:35:14 +0800 Subject: [PATCH] vim-patch:9.1.1776: completion: "adding" expansion doesn't work with cfc=keyword (#35850) Problem: "adding" expansion doesn't work with cfc=keyword. Solution: Remove incorrect assignment to compl_cont_status. Don't use fuzzy collection in "adding" status (zeertzjq). related: neovim/neovim#35842 closes: vim/vim#18351 https://github.com/vim/vim/commit/e19a882ffc389f7593c59b0b2df47adaf6afb6af --- src/nvim/insexpand.c | 8 +++----- test/old/testdir/test_ins_complete.vim | 8 ++++++++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/nvim/insexpand.c b/src/nvim/insexpand.c index eff661dc6d..56748eb645 100644 --- a/src/nvim/insexpand.c +++ b/src/nvim/insexpand.c @@ -4291,8 +4291,9 @@ static int get_next_default_completion(ins_compl_next_state_T *st, pos_T *start_ { char *ptr = NULL; int len = 0; - bool in_fuzzy_collect = (cfc_has_mode() && compl_length > 0) - || ((get_cot_flags() & kOptCotFlagFuzzy) && compl_autocomplete); + bool in_fuzzy_collect = !compl_status_adding() + && ((cfc_has_mode() && compl_length > 0) + || ((get_cot_flags() & kOptCotFlagFuzzy) && compl_autocomplete)); char *leader = ins_compl_leader(); int score = FUZZY_SCORE_NONE; const bool in_curbuf = st->ins_buf == curbuf; @@ -6065,9 +6066,6 @@ static int ins_compl_start(void) compl_length = 0; compl_col = curwin->w_cursor.col; compl_lnum = curwin->w_cursor.lnum; - } else if (ctrl_x_mode_normal() && cfc_has_mode()) { - compl_startpos = curwin->w_cursor; - compl_cont_status &= CONT_S_IPOS; } } else { edit_submode_pre = NULL; diff --git a/test/old/testdir/test_ins_complete.vim b/test/old/testdir/test_ins_complete.vim index d08ba57513..af1ab51c18 100644 --- a/test/old/testdir/test_ins_complete.vim +++ b/test/old/testdir/test_ins_complete.vim @@ -3718,6 +3718,14 @@ func Test_complete_fuzzy_collect() call feedkeys("A\\\\0", 'tx!') call assert_equal('你的 我的 我的', getline('.')) + " check that "adding" expansion works + call setline(1, ['hello world foo bar']) + call feedkeys("Ohlo\\\\\\\\\0", 'tx!') + call assert_equal('hello world foo bar', getline('.')) + call feedkeys("Swld\\\\\\\0", 'tx!') + call assert_equal('world foo bar', getline('.')) + %delete + " fuzzy on file call writefile([''], 'fobar', 'D') call writefile([''], 'foobar', 'D')