mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-01 07:28:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(float): close preview float window when no selected #29745

Browse Source 
Problem: Float preview window still exist when back at original.
Or no info item is selected.

Solution: if selected is -1 or no info is selected, if float preview
window exist close it first.
This commit is contained in:
glepnir
2024-12-11 21:20:10 +08:00
committed by GitHub
parent 3dfb9e6f60
commit ff1791c9e5
2 changed files with 112 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/nvim/popupmenu.c
View File

@@ -941,11 +941,14 @@ static bool pum_set_selected(int n, int repeat)
pum_selected = n;
unsigned cur_cot_flags = get_cot_flags();
bool use_float = (cur_cot_flags & kOptCotFlagPopup) != 0;
// when new leader add and info window is shown and no selected we still
// need use the first index item to update the info float window position.
bool force_select = use_float && pum_selected < 0 && win_float_find_preview();
if (force_select) {
pum_selected = 0;
// Close the floating preview window if 'selected' is -1, indicating a return to the original
// state. It is also closed when the selected item has no corresponding info item.
if (use_float && (pum_selected < 0 || pum_array[pum_selected].pum_info == NULL)) {
win_T *wp = win_float_find_preview();
if (wp) {
win_close(wp, true, true);
}
}
if ((pum_selected >= 0) && (pum_selected < pum_size)) {
@@ -1164,11 +1167,6 @@ static bool pum_set_selected(int n, int repeat)
}
}
// restore before selected value
if (force_select) {
pum_selected = n;
}
return resized;
}