Lewis Russell
e67cd22c38
fix(signcol): handle edge case with maximum value
...
50250542
failed to consider that the maximum passed to buf_signcols
is window scoped whereas the signcols value is buffer scoped. This can
lead to a bug where the signcolumn becomes incorrect if:
- global signcolumn is set to auto:N
- signcolumn in a window is changed locally to auto:M where M > N
- the buffer has a line with M or greater signs.
2022-02-24 22:35:59 +00:00
zeertzjq
dcefd48c1b
vim-patch:8.2.0156: various typos in source files and tests
...
Problem: Various typos in source files and tests.
Solution: Fix the typos. (Emir Sari, closes vim/vim#5532 )
4b96df5a01
2022-02-14 18:56:30 +08:00
zeertzjq
dc415ce298
vim-patch:8.1.2184: option context is not copied when splitting a window
...
Problem: Option context is not copied when splitting a window. (Daniel
Hahler)
Solution: Copy the option context, so that ":verbose set" works.
(closes vim/vim#5066 )
cfb381421f
vim-patch:8.2.3804: script context not set when copying 'swf' and 'ts'
Problem: Script context not set when copying 'swf' and 'ts'.
Solution: Use COPY_OPT_SCTX with the right argument. (closes vim/vim#9347 )
6206877c51
2022-02-13 05:40:13 +08:00
Lewis Russell
50250542c3
refactor(signs): more efficient signcol calc
...
When iterating signs to calculate the sign column, stop iterating when
we reach the maximum configured from 'signcolumn'.
2022-02-12 17:56:39 +00:00
zeertzjq
612696bedc
vim-patch:8.1.2073: when editing a buffer 'colorcolumn' may not work
...
Problem: When editing a buffer 'colorcolumn' may not work.
Solution: Set the buffer before copying option values. Call
check_colorcolumn() after copying window options.
010ee9657a
2022-02-12 06:36:17 +08:00
zeertzjq
e6cfd20b7f
vim-patch:8.2.4298: divide by zero with huge tabstop value
...
Problem: Divide by zero with huge tabstop value.
Solution: Reject tabstop value that overflows to zero.
fc88df42f1
2022-02-05 20:05:04 +08:00
zeertzjq
89e308d7da
Merge pull request #17226 from dundargoc/refactor/remove-redundant-code
...
vim-patch:8.2.4241: some type casts are redundant
2022-02-03 20:47:29 +08:00
Sean Dewar
c00b844988
Merge pull request #17231 from seandewar/vim-8.2.4245
...
vim-patch:8.2.4245: ":retab 0" may cause illegal memory access
2022-01-31 18:28:56 +00:00
Dundar Göc
2793fcae0a
vim-patch:8.2.4241: some type casts are redundant
...
Problem: Some type casts are redundant.
Solution: Remove the type casts. (closes vim/vim#9643 )
420fabcd4f
This is not a literal port but an equivalent one.
2022-01-30 19:16:51 +01:00
Björn Linse
baec0d3152
feat(provider)!: remove support for python2 and python3.[3-5]
...
These versions of python has reached End-of-life. getting rid
of python2 support removes a lot of logic to support two
incompatible python versions in the same version.
2022-01-29 19:49:37 +01:00
Sean Dewar
15c9d88bb7
vim-patch:8.2.4245: ":retab 0" may cause illegal memory access
...
Problem: ":retab 0" may cause illegal memory access.
Solution: Limit the value of 'tabstop' to 10000.
652dee4486
ex_retab change is N/A (+vartabs always available).
Nvim's set_num_option validation logic was refactored, hence why it looks
different from Vim's.
Also use XFREE_CLEAR in other places.
2022-01-29 06:31:51 +00:00
Sean Dewar
14751eaf70
Merge pull request #16954 from f380cedric/vim-8.2.3402
...
vim-patch:8.2.{3402,3403}
2022-01-27 23:05:43 +00:00
f380cedric
503e6f7832
vim-patch:8.2.3403: memory leak for :retab with invalid argument
...
Problem: Memory leak for :retab with invalid argument.
Solution: Free the memory. Make error messages consistent.
2ddb89f8a9
Changes in ex_retab are N/A (behind a non-FEAT_) and have been dropped.
2022-01-27 23:37:01 +01:00
bfredl
480fbbe296
Merge pull request #17145 from zeertzjq/vim-8.2.0128
...
vim-patch:8.2.0128: cannot list options one per line
2022-01-27 08:37:36 +01:00
zeertzjq
aa4eadd2be
vim-patch:8.2.0128: cannot list options one per line
...
Problem: Cannot list options one per line.
Solution: Use ":set!" to list one option per line.
6b915c0c0e
2022-01-20 14:34:24 +08:00
f380cedric
5e81687d9a
vim-patch:8.2.3402: invalid memory access when using :retab with large value
...
Problem: Invalid memory access when using :retab with large value.
Solution: Check the number is positive.
b7081e135a
2022-01-18 10:04:32 +01:00
zeertzjq
87e54f123a
vim-patch:8.2.3280: 'virtualedit' local to buffer is not the best solution
...
Problem: 'virtualedit' local to buffer is not the best solution.
Solution: Make it window-local. (Gary Johnson, closes vim/vim#8685 )
51ad850f5f
2022-01-15 19:21:17 +08:00
zeertzjq
d391940b9a
vim-patch:8.2.3227: 'virtualedit' can only be set globally
...
Problem: 'virtualedit' can only be set globally.
Solution: Make 'virtualedit' global-local. (Gary Johnson, closes vim/vim#8638 )
53ba05b090
I changed some macros to unsigned integer literals to avoid compiler warnings.
2022-01-15 19:21:17 +08:00
dundargoc
6e00d4754c
vim-patch:8.2.3914 ( #16808 )
...
* vim-patch:8.2.3914: various spelling mistakes in comments
Problem: Various spelling mistakes in comments.
Solution: Fix the mistakes. (Dominique Pellé, closes vim/vim#9416 )
af4a61a85d
Co-authored-by: zeertzjq <zeertzjq@outlook.com >
2021-12-28 11:28:48 +01:00
Jan Edmund Lazo
397201f2c6
Merge pull request #16705 from zeertzjq/vim-8.2.2508
...
vim-patch:8.2.{2508,2641,3846}
2021-12-25 19:08:36 -05:00
Sean Dewar
70a68dc2c5
fix(options): disallow empty 'fdc' and 'scl' ( #16765 )
...
Empty string values for these options aren't actually allowed, but
check_opt_strings allows empty string options.
It so happens that 'scl' handles empty string like "auto", but empty 'fdc'
causes glitchiness (win_fdccol_count returns an incorrect value).
Just disallow empty string values for these options completely.
2021-12-24 22:30:34 -07:00
Gregory Anders
33cd1ba00a
fix(api): make nil value in nvim_set_option_value clear local value ( #16710 )
...
For special options such as 'undolevels' and 'scrolloff', this sets the
local value to the special "unset" value (e.g. -12345 for 'undolevels').
2021-12-21 14:20:34 -07:00
zeertzjq
0e18cf4b6d
vim-patch:8.2.3846: no error when using control character for 'lcs' or 'fcs'
...
Problem: No error when using control character for 'lcs' or 'fcs'.
Solution: Use char2cells() to check the width. (closes vim/vim#9369 )
60618c8f1a
2021-12-19 09:55:17 +08:00
Björn Linse
df54d82b7c
refactor(misc1): move out high-level input functions to a new file: input.c
...
Possibly dialog code is messages.c could be moved here as well.
misc1.c is now empty, so delete it.
2021-12-10 18:15:33 +01:00
Björn Linse
26eb605152
Merge pull request #16597 from bfredl/nomisc1
...
refactor: move out some long-hanging fruit from misc1.c
2021-12-10 10:56:17 +01:00
Björn Linse
d9c1669a54
refactor(misc1): move out misc functions which obviously belong elsewhere
...
Also make some function names more descriptive/regular.
2021-12-09 23:17:29 +01:00
James McCoy
e8f9262125
vim-patch:8.2.3664: cannot adjust sign highlighting for 'cursorline'
...
Problem: Cannot adjust sign highlighting for 'cursorline'.
Solution: Add CursorLineSign and CursorLineFold highlight groups.
(Gregory Anders, closes vim/vim#9201 )
e413ea04b7
2021-12-08 21:47:58 -05:00
Jan Edmund Lazo
18d81a6724
Merge pull request #16107 from zeertzjq/vim-8.1.1542
...
vim-patch:8.1.1542,8.2.3549: an OptionSet autocommand does not get enough info
2021-12-06 22:35:05 -05:00
Gregory Anders
71ac00ccb5
feat(api): add nvim_get_option_value
2021-12-04 14:04:23 -07:00
zeertzjq
d40db0edbd
vim-patch:8.1.1542: an OptionSet autocommand does not get enough info
...
Problem: An OptionSet autocommand does not get enough info.
Solution: Add v:option_command, v:option_oldlocal and v:option_oldglobal.
(Latrice Wilgus, closes vim/vim#4118 )
d7c9687947
2021-11-22 15:50:14 +08:00
Jan Edmund Lazo
64abd7be79
Merge pull request #16341 from zeertzjq/vim-8.2.2518
...
vim-patch:8.2.{2518,2520,3572,3588}: 'listchars' (and 'fillchars'?) fixes
2021-11-21 22:21:32 -05:00
dundargoc
725cbe7d41
refactor: saner options for uncrustify ( #16204 )
...
* sp_enum_after_assign = force
* sp_brace_typedef = force
* nl_do_brace = remove
* sp_do_brace_open = force
* sp_brace_close_while = force
* sp_before_semi = remove
* sp_before_semi_for = remove
* sp_before_semi_for_empty = remove
* sp_between_semi_for_empty = remove
* sp_after_semi_for_empty = remove
* sp_before_square = remove
* sp_before_squares = remove
* sp_inside_square = remove
* sp_inside_fparens = remove
* sp_inside_fparen = remove
* sp_inside_tparen = remove
* sp_after_tparen_close = remove
* sp_return_paren = force
* pos_bool = lead
* sp_pp_concat = remove
* sp_pp_stringify = remove
* fixup: disable formatting for the INIT section
2021-11-19 14:21:53 -05:00
zeertzjq
5ff972cafe
vim-patch:8.2.3522: cannot use \x and \u when setting 'listchars' ( #16049 )
...
Problem: Cannot use \x and \u when setting 'listchars'.
Solution: Support hex and unicode in hex form. (closes vim/vim#9006 )
93ff6720fe
2021-11-17 20:55:59 -05:00
zeertzjq
145fc69df9
vim-patch:8.2.3588: break statement is never reached
...
Problem: Break statement is never reached.
Solution: Rely on return value of set_chars_option() not changing.
(closes vim/vim#9103 )
606efc7df4
2021-11-17 07:11:46 +08:00
zeertzjq
7528bcec42
fix(options): using :set fillchars should clear local value
2021-11-17 07:11:46 +08:00
zeertzjq
8c24e1462c
vim-patch:8.2.2518: 'listchars' should be window-local
...
Problem: 'listchars' should be window-local.
Solution: Make 'listchars' global-local. (Yegappan Lakshmanan, Marco Hinz,
closes vim/vim#5206 , closes vim/vim#7850 )
eed9d46293
Nvim already has this feature, but it implements :set listchars the same
as :setglobal listchars, which is incorrect. Vim's implementation of
:set listchars is correct: using :set listchars clears local value.
2021-11-17 07:11:40 +08:00
dundargoc
eba317d7a9
refactor: reduce number of explicit char casts ( #16077 )
...
* refactor: reduce number of explicit char casts
2021-11-16 20:27:59 +01:00
Jan Edmund Lazo
8f984dc1f2
Merge pull request #16047 from mcepl/vim-8.2.3520
...
vim-patch:8.2.3520: cannot define a function for thesaurus completion
2021-11-14 21:23:42 -05:00
Björn Linse
9f27e6cbe7
refactor(multibyte): eliminate mb_char2cells alias for utf_char2cells
2021-11-14 12:49:09 +01:00
Matěj Cepl
2dc0af3a4f
vim-patch:8.2.3528: 'thesaurus' and 'thesaurusfunc' do not have the same scope
...
Problem: 'thesaurus' and 'thesaurusfunc' do not have the same scope.
Solution: Make 'thesaurusfunc' global-local.
f4d8b76d30
2021-11-06 14:24:46 +01:00
James McCoy
e6ff154be6
vim-patch:8.1.0779: argument for message functions is inconsistent
...
Problem: Argument for message functions is inconsistent.
Solution: Make first argument to msg() "char *".
32526b3c18
2021-11-01 06:41:29 -04:00
James McCoy
efa924f66b
vim-patch:8.1.0743: giving error messages is not flexible
...
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
vim/vim#3302 ) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
f9e3e09fdc
2021-11-01 06:41:28 -04:00
dundargoc
a68faed02d
refactor: saner options for uncrustify #16196
...
* refactor: general good option changes
sp_deref = remove
sp_not = remove
sp_inv = remove
sp_inside_paren_cast = remove
mod_remove_duplicate_include = true
sp_after_semi = add
sp_after_semi_for = force
sp_sizeof_paren = remove
nl_return_expr = remove
nl_else_brace = remove
nl_else_if = remove
* refactor: mod_remove_extra_semicolon = true
* refactor: nl_max = 3
* refactor: sp_bool = force
* refactor: sp_compare = force
* refactor: sp_inside_paren = remove
* refactor: sp_paren_paren = remove
* refactor: sp_inside_sparen = remove
* refactor: sp_before_sparen = force
* refactor: sp_sign = remove
* refactor: sp_addr = remove
* refactor: sp_member = remove
* refactor: nl_struct_brace = remove
* refactor: nl_before_if_closing_paren = remove
* refactor: nl_fdef_brace = force
* refactor: sp_paren_comma = force
* refactor: mod_full_brace_do = add
2021-10-31 17:03:08 -07:00
dundargoc
4472c56d54
refactor: uncrustify #16090
2021-10-29 17:23:20 -07:00
Matěj Cepl
b092171e7c
vim-patch:8.2.3525: option variable name does not match option name
...
Problem: Option variable name does not match option name. (Christ van
Willigen)
Solution: Rename the variable.
d4c4bfa007
2021-10-24 08:57:30 +02:00
Matěj Cepl
cbec765915
vim-patch:8.2.3520: cannot define a function for thesaurus completion
...
Problem: Cannot define a function for thesaurus completion.
Solution: Add 'thesaurusfunc'. (Yegappan Lakshmanan, closes vim/vim#8987 ,
closes 8950)
160e994d76
2021-10-23 22:30:50 +02:00
Dundar Göc
ce441b8b13
vim-patch:8.1.2392: using old C style comments
...
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
6e0ce171e1
2021-10-21 12:07:14 +02:00
dundargoc
81717d2461
vim-patch:8.1.2243: typos in comments ( #16104 )
...
Problem: Typos in comments.
Solution: Fix the typos. (Dominique Pelle, closes vim/vim#5160 ) Also adjust
formatting a bit.
32aa10203b
2021-10-20 12:19:14 -07:00
dundargoc
aff444659e
fix(PVS/V1028): prevent possible overflow #16023
...
Full warning: "Possible overflow. Consider casting operands, not the
result."
https://pvs-studio.com/en/docs/warnings/v1028/
2021-10-17 17:11:23 -07:00
Jan Edmund Lazo
77e6ecf85a
Merge pull request #15930 from dundargoc/vim-patch/old-style-c-comments
...
vim-patch:8.1.2396,8.1.2395,8.1.2394,8.1.2392,8.1.2368,8.1.2388,8.1.2379
2021-10-17 10:21:40 -04:00