ZyX
b7a46f2299
eval/typval: Remove struct dictitem_S which is not used anywhere
2018-04-20 00:04:25 +03:00
Björn Linse
be1448213c
Merge pull request #8291 from bfredl/ui_resize
...
ui_events: correct wrong argument order in resize event
2018-04-19 10:22:19 +02:00
Justin M. Keyes
a1530ece87
Merge #8293 from justinmk/test-nodejs
...
test: nodejs_spec: allow more time for nodejs init
2018-04-18 19:58:05 +02:00
Justin M. Keyes
522443d6bf
test/util: retry(): also decorate non-string error
2018-04-18 09:47:51 +02:00
Justin M. Keyes
1dc497398e
test: nodejs_spec: allow more time for nodejs init
2018-04-18 09:42:56 +02:00
Björn Linse
c8189096e8
ui_events: correct wrong argument order
2018-04-17 19:09:18 +02:00
Justin M. Keyes
7a13611ba2
Merge #8276 'startup: Make -s - read from stdin'
2018-04-17 10:33:36 +02:00
ZyX
8cdaac0d80
event/process: Silence PVS/V547: assuming stream->num_bytes changes
...
Not familiar with the code, but I assume that loop_poll_events can actually
change stream->num_bytes, so condition is not always false.
2018-04-17 01:49:46 +03:00
ZyX
cb3bb0becb
pvscheck: Add --update switch
2018-04-17 01:44:11 +03:00
ZyX
57c66bc168
pvscheck: Remove outputs before running plog-converter
...
plog-converter behaviour is not the best one when creating fullhtml report and
directory already exists: it puts report inside an existing directory. Not sure
what exactly it does if inside exists as well, but if I am not mistaking report
will not be created.
2018-04-17 01:37:58 +03:00
ZyX
eba61fbc97
path: Silence PVS/V557: impossible to reach with NUL-terminated string
2018-04-17 01:36:18 +03:00
ZyX
4a1251206a
path: Fix PVS/V560: condition is essentially A && A
2018-04-17 01:07:16 +03:00
Justin M. Keyes
48967695c4
test: tui_spec.lua: relax test ( #8289 )
...
Sometimes an extra FocusGained/FocusLost event might trigger. This
doesn't matter, we just want to test that the events were received in
cmdline-mode.
2018-04-16 23:35:58 +02:00
Justin M. Keyes
0cec184cd6
startup: ignore -X
...
closes #8285
2018-04-16 22:38:02 +02:00
Andrew Pyatkov
84359a467f
terminal: resize to the max dimensions ( #8249 )
...
closes #8096
2018-04-16 22:25:23 +02:00
Marco Hinz
9a1f57b488
contrib: fix local.mk.example ( #8286 )
...
We have two ways to disable third-party/
1. make USE_BUNDLED_DEPS=OFF
2. cmake USE_BUNDLED=OFF
The example used the make option in a cmake context.
2018-04-16 21:21:44 +02:00
ZyX
fab09ea0d6
option: Silence PVS/V547: expression is true on 64-bit systems
2018-04-16 11:37:39 +03:00
ZyX
d0850586df
option: Fix PVS/V547: var is always NULL at that point
2018-04-16 11:36:06 +03:00
ZyX
6a5b9de546
option: Fix PVS/V560: EXPAND_BOOL_SETTINGS already caused early return
2018-04-16 11:34:26 +03:00
ZyX
61b6eb926d
option: Fix PVS/V547: allocator never returns NULL now
2018-04-16 11:33:11 +03:00
ZyX
d66217ab6d
option: Fix PVS/V517: duplicate check for titlelen
2018-04-16 11:32:00 +03:00
ZyX
0eb1d7ca4c
option: Silence PVS/V594: GLOBAL_WO macros is not really necessary
...
In that case it is completely possible to just use w_allbuf_opt directly.
2018-04-16 11:31:27 +03:00
ZyX
95cc2507c9
ops: Fix PVS/V560: pre may not be zero as that was already checked
2018-04-16 11:23:22 +03:00
Justin M. Keyes
ed6a113804
Merge #8273 'job-control: avoid kill-timer race'
2018-04-16 08:44:28 +02:00
ZyX
fc1ebb060e
ops: Fix PVS/V614: use of uninitialized variable
...
I have actually no idea how code managed to work and not trigger ASAN/etc here.
It does not look like a false positive at all.
2018-04-15 21:49:47 +03:00
ZyX
dae1975394
ops: Fix PVS/V547: allocator never returns NULL
2018-04-15 21:46:32 +03:00
ZyX
2b7a8ceeb6
ops: Fix PVS/V547: did_change is almost always set
...
Only exception is early `goto theend`.
2018-04-15 21:44:36 +03:00
ZyX
4a145f2036
ops: Silence PVS/V614: regtype is always initialized
2018-04-15 21:40:30 +03:00
ZyX
3b32e717d9
message: Fix PVS/V547: c is never equal to KS_ZERO
...
Since `c` there is a result of evaluating `TO_SPECIAL` macros it may be only one
of the following three things:
1. K_SPECIAL
2. K_ZERO (note: not KS_ZERO)
3. negative integer resulting from evaluating TERMCAP2KEY macro.
All variants here are negative and thus fail next !IS_SPECIAL(c) check (negative
is special). If `c` was really NUL it would fall into the `!IS_SPECIAL(c)` block
and use whatever character is third in `<80>{a}{b}` combo. For `<Nul>` it is
X (`<80><ff>X`).
2018-04-15 21:32:26 +03:00
ZyX
cb3230776e
memline: Fix PVS/V547: allocator now never returns NULL
2018-04-15 20:56:42 +03:00
ZyX
2940af8321
memline: Fix PVS/V560: allocator now never returns NULL
2018-04-15 20:55:26 +03:00
ZyX
a2f9188418
mbyte: Fix PVS/V557: do not do useless job
...
I do not see how array overrun is actually possible, but still EUC encodings may
do fine without a cycle.
2018-04-15 20:53:29 +03:00
ZyX
24ee261317
if_cscope: Fix PVS/V560: condition would result in earlier return
...
Previous block just checks for totmatches being zero and returns if it is. And
totmatches is unsigned, so `totmatches > 0` may never be true.
2018-04-15 20:36:21 +03:00
ZyX
b8f69b6b9a
os/fs: Fix PVS/V560: condition was already checked in while()
...
It is not possible to enter while loop body with unsigned2 == 0 if loop
condition requires unsigned1 < unsigned2.
2018-04-15 20:34:27 +03:00
ZyX
3189841984
fileio: Silence PVS/V614: buffer is initialized if conv_restlen > 0
2018-04-15 20:32:21 +03:00
ZyX
cd27198526
fileio: Fix PVS/V547: split is not used
...
This is removed functionality, specifically no longer supported 16-bit integers.
2018-04-15 20:30:31 +03:00
ZyX
1fb4282f1c
fileio: Fix PVS/V560: end was already checked
...
See condition at line 3309.
2018-04-15 20:27:41 +03:00
ZyX
11f6411771
file_search: Silence PVS/V614: used buffer is never uninitialized
2018-04-15 20:18:20 +03:00
ZyX
d084628c4b
kvec: Silence PVS/V512: it is not needed to fill the whole array
2018-04-15 20:14:55 +03:00
ZyX
a20261fae7
viml/parser/expressions: Fix PVS/V547: condition checked earlier
...
See previous goto with the same label.
2018-04-15 20:11:21 +03:00
ZyX
bc235bf1f6
viml/parser/expressions: Fix PVS/V547: condition checked earlier
...
See previous goto with the same label.
2018-04-15 20:10:48 +03:00
ZyX
6196738a3b
ex_cmds: Fix PVS/V547: expression was already checked in outer if()
2018-04-15 20:08:32 +03:00
ZyX
17e21eae24
eval: Silence PVS/V547: PVS cannot stand !known_val expressions
2018-04-15 20:07:07 +03:00
ZyX
092b4d9774
*: Add some PVS comments
2018-04-15 20:07:07 +03:00
ZyX
469ba2fb49
ex_getln: Fix PVS/V547: function is stated to never return NULL
2018-04-15 20:07:07 +03:00
ZyX
c90e9df5b5
ex_getln: Fix PVS/V560: there are no longer NULL returns for OOM
2018-04-15 20:07:07 +03:00
ZyX
cad616c94e
ex_docmd: Fix PVS/V547: condition was already checked in surr. if()
2018-04-15 20:07:07 +03:00
ZyX
d7e4449adb
ex_docmd: Fix PVS/V547: due to short-circuiting name_len is never > 4
2018-04-15 20:07:07 +03:00
ZyX
103be37f42
ex_cmds: Fix PVS/V557: possible array overrun in :ascii
...
Some calculation show that with the current setup there will not be enough bytes
occupied for that, barring the case of malicious translation. Still should be
possible to have array overrun with specially crafted translation.
2018-04-15 20:07:07 +03:00
Justin M. Keyes
b2c066409d
job-control: children_kill_cb(): do not check elapsed time
...
1. Don't check elapsed time in children_kill_cb(), it's already implied
by the start-time of the timer itself.
2. Restart timer from children_kill_cb() for PTY jobs, to send SIGKILL
after SIGTERM. There is an edge case where SIGKILL might follow
SIGTERM too quickly, if jobstop() is called near the 2-second timer
window. But this edge case is not worth code complication.
2018-04-15 18:23:11 +02:00