Problem: ModeChanged autocmd not executed when Visual mode is ended with
CTRL-C.
Solution: Do not trigger the autocmd when got_int is set. (closesvim/vim#11394)
61c4b04799
Cherry-pick removal of cmdwin feature check from patch 9.0.0663.
(cherry picked from commit 0b3328d15a)
It is not safe to remove the float grid when autocommands can still be
triggered, as autocommands may use the float grid.
(cherry picked from commit 9a5e80af56)
Duplicating get_option_value() logic for an obscure future refactor
isn't really worthwhile, and findoption() isn't used anywhere else
outside the options code.
(cherry picked from commit 09841ccbc3)
Problem: screenpos() column result in fold may be too small.
Solution: Add space of 'number', sign column, etc. (closesvim/vim#11715)
ba2d191932
(cherry picked from commit 56b77dc171)
Problem: Test fails when terminal feature is missing.
Solution: Use CheckRunVimInTerminal.
b9603f6498
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit 95c655fedc)
Problem: Using freed memory with the cmdline popup menu.
Solution: Clear the popup menu when clearing the matches. (closesvim/vim#11677)
038e6d20e6
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit 4d22424d9e)
* fix(chansend): sending lines to terminal in reverse order on Windows #19315
Problem: `chansend()` on Windows sends lines in reverse order.
Cause: Using \n instead of \r\n for newlines on Windows.
Solution: on Windows, use CRLF newline characters.
Fixes#18501
(cherry picked from commit d5004aab27)
* fixup! fix(chansend): sending lines to terminal in reverse order on Windows #19315
(cherry picked from commit d313491a8b)
Co-authored-by: Enan Ajmain <3nan.ajmain@gmail.com>
Co-authored-by: Justin M. Keyes <justinkz@gmail.com>
Problem: ml_get error when using screenpos().
Solution: Give an error for the line number. (closesvim/vim#11661)
99d19438ca
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit 0909d987fe)
Problem: screenpos() does not handle a position in a closed fold.
Solution: Check if the position is inside a closed fold. (closesvim/vim#9778)
4556a2e868
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit 10af0549df)
Problem: screenpos() has non-zero row for invisible text.
Solution: Only add the window row when the text is visible. (closesvim/vim#9618)
7924a17791
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit 6f9cda0f0a)
Problem: screenpos() is wrong when the last line is partially visible and
'display' is "lastline".
Solution: Also compute the position for a partially visible line.
(closesvim/vim#8599)
189663bdac
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit 11d2704274)
vim-patch:86e6717ace4f
Problem: Crash when using win_move_statusline() in another tab page.
Solution: Check for valid window pointer. (issue vim/vim#11427)
86e6717ace
Co-authored-by: Bram Moolenaar <Bram@vim.org>
(cherry picked from commit d2a22242fb)
all pointers returned by arena_alloc residing in arena block should be
properly aligned
to meet neovim's alignment requirements but keeping it simple settle on
ARENA_ALIGN = MAX(sizeof(void *), sizeof(double)).
(cherry picked from commit 0240fd6d0f)
docs(api): pattern is not expanded for autocommands
Problem: Unlike `:autocmd`, `nvim_create_autocommand()` does not expand
environment variables in the `pattern`, which is unexpected.
Solution: Add a note to the documentation explaining this and suggesting
using `expand()` explicitly.
(cherry picked from commit eeaf943ca3)
Co-authored-by: Christian Clason <c.clason@uni-graz.at>
Problem: 'langmap' works differently when there are modifiers.
Solution: Only apply 'langmap' to a character where modifiers have no
effect. (closesvim/vim#11395, closesvim/vim#11404)
49660f5139
(cherry picked from commit e8877c4d7b)
build: don't append git tag on release versions
This prevents duplicate version strings such as v0.8.0-v0.8.0.
Also change the format for git releases from v0.9.0-dev-67-g625ba79be
to v0.9.0-dev-67+g625ba79be. The neovim versions are now:
release: v0.9.0
prerelease without git info: v0.9.0-dev
prerelease with git info: v0.9.0-dev-67+g625ba79be
(cherry picked from commit 90785aafe1)
Co-authored-by: dundargoc <gocdundar@gmail.com>
fix(highlight): link more treesitter groups by default
Problem: Captures used by bundled parsers are not highlighted by default
Solution: Add links to default groups
A link is added for a capture if
* there is a default group of the same name (e.g., `@tag` -> `Tag`)
* it's used in a bundled query and doesn't have a reasonable fallback
(e.g., `@text.literal`)
Also add all linked groups to the treesitter docs.
(cherry picked from commit 0ee8b88b10)
Co-authored-by: Christian Clason <c.clason@uni-graz.at>
Problem: Mouse column not correctly used for popup_setpos.
Solution: Adjust off-by-one error and handle Visual line selection properly.
(Yee Cheng Chin, closesvim/vim#11356)
17822c507c
The test_termcodes.vim test cannot be used. Use a Lua test instead.
(cherry picked from commit 72d2f5aef4)
Problem: User command does not get number from :tab modifier.
Solution: Include the number. (closesvim/vim#11393, closesvim/vim#6901)
208567e9d7
(cherry picked from commit a43a46f1e6)
If the call to `qf_setup_state()` in `qf_init_ext()` fails, control flow jumps
to label `qf_init_end` where a call to `qf_update_buffer()` is made with
`old_last` as a function call argument.
Prior to this patch, `old_last` would not yet have been initialized to its
default value of `NULL`, resulting in `qf_update_buffer()` attempting to compare
against its uninitialized value (quickfix.c:3882) then later forwarding it to
`qf_fill_buffer()` where the address is dereferenced and repeatedly read from/
written to for performing core qflist operations.
Depending on what the default value of `old_last` was, the results may range
from a best case scenario of neovim terminating with SIGSEGV from an attempt to
dereference an invalid pointer (quickfix.c:4056) to memory corruption if it
contained some other value that results in `qfp` being initialized from
`old_last->qf_next` (after which it is subsequently written to and read from in
a fairly arbitrary fashion).
Though extremely unlikely, it's possible for there to be security considerations
as a user can ensure that the next call to `qf_setup_state()` fails.
This patch ensures that `old_last` is NULL-assigned before control flow jumps to
`qf_init_end`.
Closes#20639.
(cherry picked from commit 8a762eba60)
Problem: SpellFileMissing autocmd may delete buffer.
Solution: Disallow deleting the current buffer to avoid using freed memory.
ef976323e7
(cherry picked from commit 6bc2d6b66b)
