zeertzjq
721ea8fab2
vim-patch:9.0.0096: flag "new_value_alloced" is always true
...
Problem: Flag "new_value_alloced" is always true.
Solution: Remove "new_value_alloced". (closes vim/vim#10792 )
f6782732ab
2022-07-28 06:48:36 +08:00
zeertzjq
e6b7f70294
vim-patch:9.0.0095: conditions are always true
...
Problem: Conditions are always true.
Solution: Remove useless conditions. (closes vim/vim#10802 )
122dea7007
2022-07-28 06:45:22 +08:00
dundargoc
e0eebe3087
refactor: enable -Wconversion warning for window.c ( #19537 )
...
Work on https://github.com/neovim/neovim/issues/567
2022-07-27 23:39:52 +01:00
dundargoc
dadb0d6f01
refactor: enable -Wconversion warning for eval/funcs.c ( #19541 )
...
Work on https://github.com/neovim/neovim/issues/567
2022-07-27 23:37:39 +01:00
Lewis Russell
d27e4d657b
perf(api): optimize nvim_cmd ( #19513 )
...
Reduce the amount of string allocations and length calculations.
With the following benchmark:
```lua
total = 0
for _ = 1, loops do
local start = now()
vim.api.nvim_cmd({cmd = 'let', args = {'a', '=', '1'}}, {})
total = total + (now() - start)
end
print('nvim_cmd', total / loops)
```
```
hyperfine 'nvim --clean test.lua +source +q'
```
Before: 234.5ms
After: 173.8ms
2022-07-27 23:35:01 +01:00
dundargoc
48608a1f46
refactor: enable -Wconversion warning for regexp files ( #19521 )
...
Work on https://github.com/neovim/neovim/issues/567
2022-07-28 06:08:20 +08:00
zeertzjq
e0c433833f
refactor: fix clang and PVS warnings ( #19532 )
2022-07-28 06:05:33 +08:00
zeertzjq
7d9e68669c
vim-patch:9.0.0092: plugins cannot change v:completed_item ( #19542 )
...
Problem: Plugins cannot change v:completed_item.
Solution: Make v:completed_item writeable. (Shougo Matsushita,
closes vim/vim#10801 )
61021aa318
2022-07-28 05:19:38 +08:00
bfredl
b6b9f46041
Merge pull request #19525 from dundargoc/refactor/conversion-search
...
refactor: enable -Wconversion warning for search.c
2022-07-27 19:07:45 +02:00
bfredl
18755c6b89
Merge pull request #19516 from dundargoc/refactor/conversion-mbyte
...
refactor: enable -Wconversion warning for mbyte.c
2022-07-27 19:00:40 +02:00
Christian Clason
4c3104819b
vim-patch:9.0.0093: sway config files are recognized as i3config ( #19545 )
...
Problem: Sway config files are recognized as i3config.
Solution: Recognize swayconfig separately. (James Eapen, closes vim/vim#10672 )
7abd1c6d8e
2022-07-27 18:11:59 +02:00
Gregory Anders
9b447c7ce5
vim-patch:9.0.0088: pattern for detecting bitbake files is not sufficient ( #19547 )
...
Problem: Pattern for detecting bitbake files is not sufficient.
Solution: Adjust the pattern. (Gregory Anders, closes vim/vim#10743 )
30e212dac1
2022-07-27 10:06:09 -06:00
Dundar Goc
3a40d4b759
refactor: enable -Wconversion warning for search.c
...
Work on https://github.com/neovim/neovim/issues/567
2022-07-27 16:51:25 +02:00
zeertzjq
f57432af4d
vim-patch:9.0.0090: no error when assigning bool to a string option ( #19539 )
...
Problem: No error when assigning bool to a string option with setwinvar().
Solution: Give an error (closes vim/vim#10766 )
28f84e17b0
2022-07-27 20:59:43 +08:00
Dundar Goc
335b49e129
refactor: enable -Wconversion warning for mbyte.c
...
Work on https://github.com/neovim/neovim/issues/567
2022-07-27 13:14:33 +02:00
zeertzjq
bbad7371db
vim-patch:8.2.4625: old Coverity warning for resource leak
...
Problem: Old Coverity warning for resource leak.
Solution: Call FreeWild() if expanding matches did not fail.
90da27b927
2022-07-27 12:00:56 +08:00
zeertzjq
f586131e57
vim-patch:8.2.4623: Coverity warns for using uninitialized field
...
Problem: Coverity warns for using uninitialized field.
Solution: Initialize he field to zero.
03a297c63f
Also only initialize used fields in f_fullcommand().
2022-07-27 12:00:52 +08:00
zeertzjq
79872f3770
fix(options): properly free string options ( #19510 )
2022-07-27 07:26:32 +08:00
zeertzjq
890d4023cd
vim-patch:9.0.0081: command line completion of user command may have duplicates ( #19529 )
...
Problem: Command line completion of user command may have duplicates.
(Dani Dickstein)
Solution: Skip global user command if an identical buffer-local one is
defined. (closes vim/vim#10797 )
c2842adfb2
2022-07-27 07:25:47 +08:00
zeertzjq
fc55f8263c
vim-patch:9.0.0086: tabline is not redrawn when entering command line
...
Problem: Tabline is not redrawn when entering command line.
Solution: Set "redraw_tabline". (closes vim/vim#10771 )
6791adca53
2022-07-27 06:32:40 +08:00
zeertzjq
0c0a2e4e52
vim-patch:9.0.0083: ModeChanged event not triggered when leaving cmdline window
...
Problem: ModeChanged event not triggered when leaving the cmdline window.
Solution: Call may_trigger_modechanged(). (closes vim/vim#10791 )
c9e8fd6fc7
Code is already present in Nvim. Add some other related missing changes.
2022-07-27 06:23:47 +08:00
zeertzjq
9f1dc1466e
vim-patch:9.0.0082: cannot interrupt global command from command line
...
Problem: Cannot interrupt global command from command line.
Solution: Reset got_int in another place. (closes vim/vim#10739 )
3cfae39b08
2022-07-27 06:19:43 +08:00
zeertzjq
45e2bbae83
vim-patch:9.0.0051: using CTRL-C wih :append may hang Vim
...
Problem: Using CTRL-C wih :append may hang Vim.
Solution: Reset got_int. (closes vim/vim#10729 , closes vim/vim#10728 )
f754fe6a3d
2022-07-27 06:19:43 +08:00
zeertzjq
289256337a
Merge pull request #19523 from ii14/vim-9.0.0085
...
vim-patch:9.0.0085: ":write" fails after ":file name" and the ":edit"
2022-07-27 05:58:27 +08:00
Christian Clason
7e939ddb87
vim-patch:9.0.0084: using "terraform" filetype for .tfvars file is bad ( #19526 )
...
Problem: Using "terraform" filetype for .tfvars file is bad.
Solution: use "terraform-vars", so that different completion and other
mechanisms can be used. (Radek Simko, closes vim/vim#10755 )
15b87b6610
2022-07-26 23:08:48 +02:00
ii14
4225e6ee46
vim-patch:9.0.0085: ":write" fails after ":file name" and the ":edit"
...
Problem: ":write" fails after ":file name" and the ":edit".
Solution: Reset BF_NOTEDITED when using ":edit". (closes vim/vim#10790 )
1f0dc5e84f
2022-07-26 20:57:57 +02:00
Christian Clason
2a9c9371bc
vim-patch:9.0.0073: too many files recognized as bsdl ( #19504 )
...
Problem: Too many files recognized as bsdl.
Solution: Use pattern "*.bsd" instead of "*bsd". (Martin Tournoij,
closes vim/vim#10783 )
1b67f07f76
2022-07-26 14:16:46 +02:00
zeertzjq
27116a0159
vim-patch:9.0.0076: no test for what patch 8.1.1424 fixes
...
Problem: No test for what patch 8.1.1424 fixes.
Solution: Add a test. (closes vim/vim#10789 )
92a1678d48
2022-07-26 19:37:17 +08:00
zeertzjq
ee8606d31f
vim-patch:8.1.1424: crash when popup menu is deleted while waiting for char
...
Problem: Crash when popup menu is deleted while waiting for char.
Solution: Bail out when pum_array was cleared.
5c3fb04623
2022-07-26 19:36:24 +08:00
zeertzjq
1a07044c1c
revert: "vim-patch:9.0.0061: ml_get error with nested autocommand" ( #19509 )
...
This reverts commit 6cee15da72
.
Port this again when https://github.com/vim/vim/issues/10780 is fixed.
2022-07-26 11:53:17 +08:00
zeertzjq
147cce29a6
fix(cmdline): trigger CmdlineEnter and ModeChanged earlier ( #19474 )
...
Match Vim's ordering in code.
These tests are unrelated to ext_cmdline. Move them out of that block.
2022-07-26 10:21:30 +08:00
James McCoy
88c6e02c12
Merge pull request #19508 from ii14/fix_older_cmake_makefiles
...
build: fix git version generation on makefiles with older cmake versions
2022-07-25 21:41:03 -04:00
ii14
ba662efb17
build: fix git version generation on makefiles with older cmake versions
...
When using a Makefile generator, older CMake versions are not building
custom targets when depending on their byproducts, making version
generation fail. (works on 3.19.4, fails on 3.10.2) As a workaround,
add a dependency on the custom target explicitly.
2022-07-26 02:03:13 +02:00
zeertzjq
fe159d23fd
vim-patch:9.0.0071: command overlaps with printed text in scrollback ( #19505 )
...
Problem: Command overlaps with printed text in scrollback.
Solution: Clear until end-of-line and use correct message chunk.
(closes vim/vim#10765 , closes vim/vim#10764 )
ecdc82e74e
N/A patches for version.c:
vim-patch:9.0.0070: using utfc_ptr2char_len() when length is negative
Problem: Using utfc_ptr2char_len() when length is negative.
Solution: Check value of length. (closes vim/vim#10760 )
4dc513a22c
2022-07-26 07:30:33 +08:00
zeertzjq
7961f79904
Merge pull request #19494 from zeertzjq/vim-8.2.5155
...
vim-patch:8.2.{5155,5163,5164,5166}: diff fixes
2022-07-25 21:32:30 +08:00
dundargoc
e12035fc0c
build(lint): check uncrustify version #19468
...
This to prevent the user from accidentally using the wrong uncrustify
version.
2022-07-25 06:18:49 -07:00
zeertzjq
e4079f3b5a
vim-patch:8.2.5166: test for DiffUpdated fails
...
Problem: Test for DiffUpdated fails.
Solution: Also accept a count of two.
f65cc665fa
2022-07-25 20:48:21 +08:00
zeertzjq
771564b00e
vim-patch:8.2.5164: invalid memory access after diff buffer manipulations
...
Problem: Invalid memory access after diff buffer manipulations.
Solution: Use zero offset when change removes all lines in a diff block.
c101abff4c
2022-07-25 20:48:21 +08:00
zeertzjq
8543de3a86
vim-patch:8.2.5163: crash when deleting buffers in diff mode
...
Problem: Crash when deleting buffers in diff mode.
Solution: Recompute diffs later. Skip window without a valid buffer.
cd38bb4d83
2022-07-25 20:48:21 +08:00
zeertzjq
611b43369e
vim-patch:8.2.5155: in diff mode windows may get out of sync
...
Problem: In diff mode windows may get out of sync. (Gary Johnson)
Solution: Avoid that the other window scrolls for 'cursorbind'.
a315ce1f32
2022-07-25 20:30:35 +08:00
zeertzjq
ad57610ac7
vim-patch:9.0.0066: switching window uneccarily when getting buffer options
...
Problem: Switching window uneccarily when getting buffer options.
Solution: Do not switch window when getting buffer options. (closes vim/vim#10767 )
cd6ad6439d
2022-07-25 20:01:59 +08:00
zeertzjq
56ed5a0403
vim-patch:8.2.4866: duplicate code in "get" functions
...
Problem: Duplicate code in "get" functions.
Solution: Use get_var_from() for getwinvar(), gettabvar(), gettabwinvar()
and getbufvar(). (closes vim/vim#10335 )
47d4e317f8
f_setbufvar() can use tv_get_buf_from_arg() as it sets emsg_off.
2022-07-25 20:01:59 +08:00
zeertzjq
aba3147cb6
vim-patch:8.2.4228: no tests for clicking in the GUI tabline
...
Problem: No tests for clicking in the GUI tabline.
Solution: Add test functions to generate the events. Add tests using the
functions. (Yegappan Lakshmanan, closes vim/vim#9638 )
b0ad2d92fd
2022-07-25 18:20:47 +08:00
zeertzjq
d8df9afad6
vim-patch:8.2.2969: subtracting from number option fails when result is zero
...
Problem: Subtracting from number option fails when result is zero. (Ingo
Karkat)
Solution: Reset the string value when using the numeric value.
(closes vim/vim#8351 )
a42e6e0082
Cherry-pick Test_compound_assignment_operators() changes from patch 8.2.1593
2022-07-25 18:20:47 +08:00
zeertzjq
963ea726da
vim-patch:8.2.2285: Vim9: cannot set an option to a false
...
Problem: Vim9: cannot set an option to a false.
Solution: For VAR_BOOL use string "0". (closes vim/vim#7603 )
b0d8182fa3
2022-07-25 18:20:47 +08:00
zeertzjq
8921035fc7
vim-patch:8.2.2284: Vim9: cannot set an option to a boolean value
...
Problem: Vim9: cannot set an option to a boolean value.
Solution: Check for VAR_BOOL. (closes vim/vim#7603 )
31a201a04a
2022-07-25 18:20:47 +08:00
zeertzjq
2241fd3211
vim-patch:8.2.2254: Vim9: bool option type is number
...
Problem: Vim9: bool option type is number.
Solution: Have get_option_value() return a different value for bool and
number options. (closes vim/vim#7583 )
dd1f426bd6
2022-07-25 18:20:47 +08:00
zeertzjq
3ea45a2caf
vim-patch:8.2.1469: Vim9: cannot assign string to string option
...
Problem: Vim9: cannot assign string to string option.
Solution: Change checks for option value. (closes vim/vim#6720 )
0aae4809fd
2022-07-25 18:20:45 +08:00
zeertzjq
eb77122823
fix(input): do no reinterpret mouse keys with ALT modifiers
...
Remove check for MOD_MASK_META as it is for <T- which never appears in TUI.
Make small changes to docs.
2022-07-25 09:47:28 +08:00
notomo
46e3e1c728
fix(api): make nvim_cmd mods.silent work correctly ( #19489 )
2022-07-25 09:43:39 +08:00