Commit Graph

1825 Commits

Author SHA1 Message Date
Scott Prager
2e873c8767 sha256.c: Enable -Wconvert and clint.
* Add sha256.c/h to clint-files.txt.
* Add sha256.c to CONV_SRCS in src/nvim/CMakeLists.txt.
* Use size_t for lengths and const for read-only parameters.
* Use restrict keyword.
* Refine #includes.
2015-01-02 18:07:01 -05:00
oni-link
36ba1d9fba Speed up garbage collection.
For garbage collection all lists are kept in first_list, a list of all
lists.

free_unref_items() searches through first_list and removes unreferenced
lists from it (by calling list_free(..., FALSE)). But after a list was
removed, the search continues from the beginning of first_list (not sure
how many lists were really removed and where to continue in first_list).

This is not necessary anymore since vim-patch 7.0.135, because a call to
list_free(...,FALSE) makes sure, that no other lists (and dictionaries)
are freed. So we always know, that the next list in first_list is
still valid (allocated or NULL) and can be used to continue the search.

Likewise for dictionaries.

Original patch by Ariya Mizutani
https://groups.google.com/forum/#!searchin/vim_dev/GC/vim_dev/DBYOdHQWvqY/1WH04_dwETIJ
2014-12-31 17:08:26 +01:00
Justin M. Keyes
a31bcfb98a Merge pull request #1742 from fwalch/vim-7.4.552
vim-patch:7.4.552
2014-12-30 00:10:26 -05:00
Justin M. Keyes
13d950f6ed Merge pull request #1738 from fwalch/vim-7.4.549
vim-patch:7.4.549
2014-12-30 00:03:44 -05:00
Justin M. Keyes
bb1be08bae vim-patch:7.4.487
Problem:    ":sign jump" may use another window even though the file is
	    already edited in the current window.
Solution:   First check if the file is in the current window. (James McCoy)

https://code.google.com/p/vim/source/detail?r=v7-4-487
2014-12-29 23:48:23 -05:00
Justin M. Keyes
7285b0c863 Merge pull request #1737 from fwalch/vim-7.4.541
vim-patch:7.4.541
2014-12-29 23:18:13 -05:00
oni-link
487a68ac69 vim-patch:7.4.533
Problem:    ":hardcopy" leaks memory in case of errors.
Solution:   Free memory in all code paths. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-533
2014-12-29 12:01:56 +01:00
oni-link
a3a1915684 vim-patch: Mark patches as NA
Code modified in patch 7.4.402 and 7.4.443 was introduced with
patch 7.4.399, which is also marked as NA (FEAT_CRYPT was removed).

Patch 7.4.509 needs the removed FEAT_CRYPT.
2014-12-29 00:11:18 +01:00
oni-link
a42e5eeb79 vim-patch:7.4.211
Problem:    ":lu" is an abbreviation for ":lua", but it should be ":lunmap".
            (ZyX)
Solution:   Move "lunmap" to above "lua".

https://code.google.com/p/vim/source/detail?r=e90bef2240c8d187da6e8d8fa5007ec5afc12284
2014-12-28 09:45:55 +01:00
Justin M. Keyes
bb574e2202 restore 'Not Implemented' for legacy script commands (:lua :ruby ...)
- restores behavior equivalent to Vim compiled without FEAT_MZSCHEME, etc.
  (avoids spurious "E492: Not an editor command: EOF") for code such as:
```vim
  if 0
    perl << EOF
  end
  EOF
  endif
```
  see :help script-here
- fixes #1308
- fixes https://github.com/junegunn/vim-plug/issues/111
2014-12-27 16:28:02 -05:00
Justin M. Keyes
56fdeb88b8 Merge pull request #1743 from oni-link/vim.patch.7.4.560
vim-patch: Mark patch 7.4.560 as NA
2014-12-27 08:38:35 -05:00
Florian Walch
898f01dee1 vim-patch:7.4.549
Problem:    Function name not recognized correctly when inside a function.
Solution:   Don't check for an alpha character.

https://code.google.com/p/vim/source/detail?r=v7-4-549
2014-12-27 11:38:32 +01:00
Florian Walch
0e8c39bd3b vim-patch:7.4.528
Problem:    Crash when using matchadd() (Yasuhiro Matsumoto)
Solution:   Copy the match regprog.

https://code.google.com/p/vim/source/detail?r=v7-4-528
2014-12-27 11:33:59 +01:00
oni-link
4c0e681c19 vim-patch: Mark patch 7.4.560 as NA
The memory leak fixed in 7.4.560 was fixed in
e10670ac3b. We also do not need to keep
`y_current->y_array` as is until done, because our memory allocations
cannot fail.
2014-12-27 09:51:20 +01:00
Justin M. Keyes
4ff4b9306d Merge pull request #1735 from fwalch/vim-7.4.527
vim-patch:7.4.527
2014-12-26 18:00:35 -05:00
Justin M. Keyes
775361728a Merge pull request #1734 from fwalch/small-patches
vim-patch: Multiple small patches (4)
2014-12-26 14:29:32 -05:00
Florian Walch
e27460b60c vim-patch:7.4.552
Problem:    Langmap applies to Insert mode expression mappings.
Solution:   Check for Insert mode. (Daniel Hahler)

https://code.google.com/p/vim/source/detail?r=v7-4-552
2014-12-26 16:54:24 +01:00
Justin M. Keyes
cab88790bc Merge pull request #1684 from justinmk/coverity74717
[RFC] coverity/74717: FP: NULL Pointer Dereference
2014-12-26 10:08:52 -05:00
Justin M. Keyes
1c6cd9f239 Merge pull request #1730 from fwalch/vim-7.4.486
vim-patch:7.4.486
2014-12-26 09:34:22 -05:00
Justin M. Keyes
78faf274f3 Merge pull request #1725 from fwalch/vim-7.4.450
vim-patch:7.4.450
2014-12-26 08:42:30 -05:00
Justin M. Keyes
d7a1665785 Merge pull request #1718 from jonaias/master
Transform global variable really_exiting into static.
2014-12-26 08:30:15 -05:00
oni-link
ce03171323 coverity/90712: Remove unnecessary check for NULL.
** CID 90712:  Dereference after null check  (FORWARD_NULL)
/src/nvim/getchar.c: 3654 in check_abbr()

vim_strsave() never returns NULL, so q is never NULL. Removing the
NULL check for q should fix this warning.
2014-12-26 12:26:09 +01:00
Jonas Dourado
a00c2e0ecb Transform global variable really_exiting into static. 2014-12-26 01:46:21 -02:00
Florian Walch
9854ba7276 vim-patch:7.4.486
Problem:    Check for writing to a yank register is wrong.
Solution:   Negate the check. (Zyx).  Also clean up the #ifdefs.

https://code.google.com/p/vim/source/detail?r=v7-4-486
2014-12-25 19:05:52 +01:00
Justin M. Keyes
7231a23cf6 Merge pull request #1722 from fwalch/vim-7.4.488
vim-patch:7.4.483, vim-patch:7.4.485, vim-patch:7.4.488
2014-12-25 12:57:09 -05:00
Florian Walch
4ad5b245f0 vim-patch:7.4.541
Problem:    Crash when doing a range assign.
Solution:   Check for NULL poiter. (Yukihiro Nakadaira)

https://code.google.com/p/vim/source/detail?r=v7-4-541
2014-12-25 18:54:12 +01:00
Florian Walch
28d3923bd8 vim-patch:7.4.547
Problem:    Using "vit" does not select a multi-byte character at the end
	    correctly.
Solution:   Advance the cursor over the multi-byte character. (Christian
	    Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-547
2014-12-24 23:29:00 +01:00
Florian Walch
dde24224ec vim-patch:7.4.545
Problem:    Highlighting for multi-line matches is not correct.
Solution:   Stop highlight at the end of the match. (Hirohito Higashi)

https://code.google.com/p/vim/source/detail?r=v7-4-545
2014-12-24 23:29:00 +01:00
Florian Walch
811cb036d9 vim-patch:7.4.538
Problem:    Tests fail with small features plus Python.
Solution:   Disallow weird combination of options.  Do not set "fdm" when
	    folding is disabled.

https://code.google.com/p/vim/source/detail?r=v7-4-538
2014-12-24 23:29:00 +01:00
Florian Walch
476a2c0a83 vim-patch:7.4.536
Problem:    Test 63 fails when using a black&white terminal.
Solution:   Add attributes for a non-color terminal. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-536
2014-12-24 23:29:00 +01:00
Florian Walch
0439e808cb vim-patch:7.4.521
Problem:    When using "vep" a mark is moved to the next line. (Maxi Padulo,
	    Issue 283)
Solution:   Decrement the line number. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-521
2014-12-24 23:28:59 +01:00
Eliseo Martínez
516405b601 Remove long_u: Passing-by: put_time(): Refactor implementation.
put_time() had a complicated implementation, because of having to shift
an 8-byte value in a portable way with old means.
That can be greatly simplified now, using a C99 fixed-size type.
2014-12-24 20:00:05 +01:00
Eliseo Martínez
ec09f4488f Remove long_u: Passing-by: undo.c: Add to -Wconversion.
Previous commit dropped many -Wconversion warnings in both spell.c and
undo.c. spell.c still has a lot of them (200+). But in undo.c, only a
handful of them remain. Take the chance to eliminate those, too, and add
undo.c to -Wconversion checked files.
2014-12-24 20:00:05 +01:00
Eliseo Martínez
d2745a59f8 Remove long_u: put_bytes(): Refactor.
Remove all long_u instances due to put_bytes() function.

First, function signature is changed this way:
- nr  : long_u --> uintmax_t
    uintmax_t is chosen so that invocations can use any unsigned integer
    type (including size_t) without needing to cast.
- len : int    --> unsigned int
    This is to pass the size in bytes of the previous param, thus an
    unsigned int is enough. All invocations use positive integer
    literals, so change is safe without the need for casts.

Then, function implementation is adapted accordingly.

Last, all invocation points are refactored this way:
- Refactor types to minimize casts.
- Inline declarations (C99 style) in containing function.

All this changes were done with -Wconversion temporarily activated for
spell.c and undo.c, so that we can assert changes are type-safe and do
not introduce any warnings to that respect.
2014-12-24 20:00:04 +01:00
Florian Walch
fe0801d51d vim-patch:7.4.527
Problem:    Still confusing regexp failure and NFA_TOO_EXPENSIVE.
Solution:   NFA changes equivalent of 7.4.526.

https://code.google.com/p/vim/source/detail?r=v7-4-527
2014-12-24 14:23:07 +01:00
Justin M. Keyes
59985523b8 Merge pull request #1732 from fwalch/small-patches
vim-patch: Small patches (3)
2014-12-24 00:53:00 -05:00
Florian Walch
ed9828140a Linting: Suppress warnings in os/users.c. 2014-12-24 00:32:26 -05:00
Florian Walch
0f258e4453 Linting: Fix strcpy warning. 2014-12-24 00:32:26 -05:00
Florian Walch
73a970ccd9 Linting: Fix header guards, add whitespace. 2014-12-24 00:32:26 -05:00
Florian Walch
05b2f01f6a vim-patch:7.4.518
Problem:    Using status line height in width computations.
Solution:   Use one instead. (Hirohito Higashi)

https://code.google.com/p/vim/source/detail?r=v7-4-518
2014-12-24 00:32:55 +01:00
Florian Walch
3286176406 vim-patch:7.4.516
Problem:    Completing a function name containing a # does not work.  Issue
	    253.
Solution:   Recognize the # character. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-516
2014-12-24 00:32:53 +01:00
Florian Walch
5e542ba56e vim-patch:7.4.513
Problem:    Crash because reference count is wrong for list returned by
	    getreg().
Solution:   Increment the reference count. (Kimmy Lindvall)

https://code.google.com/p/vim/source/detail?r=v7-4-513
2014-12-23 21:48:22 +01:00
Florian Walch
89bab9b90e vim-patch:7.4.520
Problem:    Sun PCK locale is not recognzed.
Solution:   Add PCK in the table. (Keiichi Oono)

https://code.google.com/p/vim/source/detail?r=v7-4-520
2014-12-23 21:35:50 +01:00
Florian Walch
df05574c97 vim-patch:7.4.508
Problem:    When generating ja.sjis.po the header is not correctly adjusted.
Solution:   Check for the right header string. (Ken Takata)

https://code.google.com/p/vim/source/detail?r=v7-4-508
2014-12-23 21:34:38 +01:00
Florian Walch
e06159e6ae vim-patch:7.4.488
Problem:    test_mapping fails for some people.
Solution:   Set the 'encoding' option. (Ken Takata)

https://code.google.com/p/vim/source/detail?r=v7-4-488
2014-12-23 21:23:49 +01:00
Florian Walch
0b192bf990 vim-patch:7.4.485
Problem:    Abbreviations don't work. (Toothpik)
Solution:   Move the length computation inside the for loop.  Compare against
	    the unescaped key.

https://code.google.com/p/vim/source/detail?r=v7-4-485
2014-12-23 21:23:32 +01:00
Florian Walch
6aecbbebfd vim-patch:7.4.483
Problem:    A 0x80 byte is not handled correctly in abbreviations.
Solution:   Unescape special characters. Add a test. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-483
2014-12-23 21:23:32 +01:00
Florian Walch
fc0be5b79d vim-patch:7.4.474
Problem:    AIX compiler can't handle // comment.  Issue 265.
Solution:   Remove that line.

https://code.google.com/p/vim/source/detail?r=v7-4-474
2014-12-23 21:17:01 +01:00
Florian Walch
5b98a4338f vim-patch:7.4.477
Problem:    When using ":%diffput" and the other file is empty an extra empty
	    line remains.
Solution:   Set the buf_empty flag.

https://code.google.com/p/vim/source/detail?r=v7-4-477
2014-12-23 21:17:01 +01:00
Florian Walch
0a20cd7f50 vim-patch:7.4.489
Problem:    Cursor movement still wrong when 'lbr' is set and there is a
	    number column. (Hirohito Higashi)
Solution:   Add correction for number column. (Hiroyuki Takagi)

https://code.google.com/p/vim/source/detail?r=v7-4-489
2014-12-23 21:17:00 +01:00