Commit Graph

17990 Commits

Author SHA1 Message Date
zeertzjq
7e1d9c560b vim-patch:8.2.2873: not enough tests for writing buffers
Problem:    Not enough tests for writing buffers.
Solution:   Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#8229)

46aa6f93ac

Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
2022-11-07 07:33:59 +08:00
zeertzjq
bdf87efeb5 vim-patch:8.2.2856: get readonly error for device that can't be written to
Problem:    Get readonly error for device that can't be written to.
Solution:   Check for being able to write first. (closes vim/vim#8205)

50157ef1c2

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-07 07:33:59 +08:00
zeertzjq
b0190f4543 vim-patch:8.2.2849: bufwrite not sufficiently tested
Problem:    Bufwrite not sufficiently tested.
Solution:   Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#8192)

36f96a5151

Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
2022-11-07 07:33:58 +08:00
zeertzjq
3b3611a3d0 vim-patch:9.0.0841: deletebufline() does not always return 1 on failure (#20980)
Problem:    deletebufline() does not always return 1 on failure.
Solution:   Refactor the code to make it work more predictable. (closes vim/vim#11511)

7af3ee2b83
2022-11-07 07:03:31 +08:00
zeertzjq
8c454776f8 vim-patch:8.2.4495: help test fails in 24 line terminal
Problem:    Help test fails in 24 line terminal.
Solution:   Use up to 23 lines for text.

e4e1a1e1c8

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 23:08:40 +08:00
zeertzjq
bfa0be49ed vim-patch:8.2.2627: no need to check for BSD after checking for not root
Problem:    No need to check for BSD after checking for not root.
Solution:   Remove CheckNotBSD. (Ozaki Kiichi, closes vim/vim#7989)

4355894869
2022-11-06 23:08:40 +08:00
zeertzjq
fbe2761b20 vim-patch:8.2.2623: some tests fail when run as root
Problem:    Some tests fail when run as root.
Solution:   Use CheckNotRoot.

17709e280a

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 23:08:40 +08:00
zeertzjq
df71537a12 vim-patch:8.2.2570: tests fail when run as root
Problem:    Tests fail when run as root.
Solution:   Add a comment mentioning the expected failure. (issue vim/vim#7919)

f9a65505d1

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 23:08:40 +08:00
zeertzjq
de500095b1 vim-patch:8.2.2592: code coverage could be improved (#20969)
Problem:    Code coverage could be improved.
Solution:   Add a few more tests. (Dominique Pellé, closes vim/vim#7957)

6fd367a97c

Test case in test_viminfo.vim is applicable.
2022-11-06 23:07:57 +08:00
zeertzjq
728c69bc8d vim-patch:8.2.1340: some tests fail on Cirrus CI and/or with FreeBSD (#20967)
Problem:    Some tests fail on Cirrus CI and/or with FreeBSD.
Solution:   Make 'backupskip' empty. Do not run tests as root. Check for
            directory when using viminfo. (Ozaki Kiichi, closes vim/vim#6596)

b86abadf87
2022-11-06 22:13:36 +08:00
zeertzjq
da0fb43849 vim-patch:8.1.1200: old style comments in debugger source
Problem:    Old style comments in debugger source.
Solution:   Use new style comments. (Yegappan Lakshmanan, closes vim/vim#4286)

31fc39e47b
2022-11-06 21:56:37 +08:00
zeertzjq
f3cea06d01 test(old): remove stray test42 files (#20966)
Forgot to remove in #17350.
2022-11-06 20:22:37 +08:00
Raphael
1af4bd04f9 feat(ui): add support to display a title in the border of a float (#20184)
add "title" and "title_pos" keys to win config dict.
2022-11-06 11:59:43 +01:00
dundargoc
731cdde28e refactor: fix clang-tidy warnings
Enable and fix bugprone-misplaced-widening-cast warning.

Fix some modernize-macro-to-enum and readability-else-after-return
warnings, but don't enable them. While the warnings can be useful, they
are in general too noisy to enable.
2022-11-06 11:44:10 +01:00
zeertzjq
a79d28e4d7 vim-patch:9.0.0265: no good reason why the "gf" command isn't in the tiny version (#20964)
Problem:    No good reason why the "gf" command is not in the tiny version.
Solution:   Graduate the file_in_path feature.

f80f40a55c

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 17:58:13 +08:00
zeertzjq
70843631fe vim-patch:8.2.3744: E854 is not tested; some spelling suggestions are not tested
Problem:    E854 is not tested; some spelling suggestions are not tested.
Solution:   Add a couple of tests. (Dominique Pellé, closes vim/vim#9279)

f645ee47c8

Add missing Test_signcolumn() from patch 7.4.2201.

Co-authored-by: Dominique Pelle <dominique.pelle@gmail.com>
2022-11-06 16:49:17 +08:00
zeertzjq
7add38233e vim-patch:8.2.3719: MS-Windows: test sometimes runs into existing swap file
Problem:    MS-Windows: test sometimes runs into existing swap file.
Solution:   Use a different file name.

f8bc0ce267

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 16:49:16 +08:00
zeertzjq
cac576322d vim-patch:8.2.1736: failure to compile a pattern not tested much
Problem:    Failure to compile a pattern not tested much.
Solution:   Add tests where a pattern fails to compile. (Yegappan Lakshmanan,
            closes vim/vim#7004)

531be47ac5
2022-11-06 16:49:11 +08:00
zeertzjq
ed01ef7fa5 vim-patch:9.0.0355: check for uppercase char in autoload name is wrong
Problem:    Check for uppercase char in autoload name is wrong, it checks the
            name of the script.
Solution:   Remove the check. (closes vim/vim#11031)

6c667bdc94

Co-authored-by: thinca <thinca@gmail.com>
2022-11-06 15:13:49 +08:00
zeertzjq
7404c6010d vim-patch:8.2.3055: strange error for assigning to "x.key" on non-dictionary
Problem:    Strange error for assigning to "x.key" on non-dictionary.
Solution:   Add a specific error message. (closes vim/vim#8451)

3a3b10e87a

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 15:13:45 +08:00
zeertzjq
95c862095f refactor(eval): make get_lval() explicitly check for v:lua
Needed for Vim patch 8.2.3055.
2022-11-06 15:13:42 +08:00
zeertzjq
d4353c3645 vim-patch:9.0.0836: wrong error when using extend() with funcref
Problem:    Wrong error when using extend() with funcref.
Solution:   Better check the variable type. (closes vim/vim#11468, closes vim/vim#11455)

91c75d18d9
2022-11-06 10:01:50 +08:00
zeertzjq
4740672b37 vim-patch:8.2.2921: E704 for script local variable is not backwards compatible
Problem:    E704 for script local variable is not backwards compatible.
            (Yasuhiro Matsumoto)
Solution:   Only give the error in Vim9 script.  Also check for function-local
            variable.

b54abeeafb

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 10:01:50 +08:00
zeertzjq
6b3db3f929 vim-patch:8.2.2920: still a way to shadow a builtin function
Problem:    Still a way to shadow a builtin function. (Yasuhiro Matsumoto)
Solution:   Check the key when using extend(). (issue vim/vim#8302)

6f1d2aa437

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 10:01:50 +08:00
zeertzjq
7683199a9b vim-patch:8.2.2918: builtin function can be shadowed by global variable
Problem:    Builtin function can be shadowed by global variable.
Solution:   Check for builtin function before variable. (Yasuhiro Matsumoto,
            closes vim/vim#8302)

3d9c4eefe6

Cherry-pick Test_gettext() from patch 8.2.2886.
2022-11-06 10:01:50 +08:00
zeertzjq
dc17df3190 fix(eval): change some tv_dict_add() usages back to hash_add()
Needed for Vim patch 8.2.2920.
2022-11-06 10:01:20 +08:00
zeertzjq
7d7208a88b vim-patch:8.2.3016: confusing error when expression is followed by comma
Problem:    Confusing error when expression is followed by comma.
Solution:   Give a different error for trailing text. (closes vim/vim#8395)

fae55a9cb0

Omit test_eval_stuff.vim and test_viminfo.vim: changes tests are N/A.

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 08:21:17 +08:00
zeertzjq
fa2ed8ca1f vim-patch:8.2.2723: assignment test fails
Problem:    Assignment test fails.
Solution:   Adjust error number.

58fb7c39a0

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 08:21:17 +08:00
zeertzjq
a208a8b10e vim-patch:8.2.2722: Vim9: crash when using LHS with double index
Problem:    Vim9: crash when using LHS with double index.
Solution:   Handle lhs_dest which is "dest_expr". (closes vim/vim#8068)
            Fix confusing error message for missing dict item.

b9c0cd897a

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 08:21:17 +08:00
zeertzjq
1f0bf65ad6 vim-patch:8.2.1306: checking for first character of dict key is inconsistent
Problem:    Checking for first character of dict key is inconsistent.
Solution:   Add eval_isdictc(). (closes vim/vim#6546)

b13ab99908

Omit handle_subscript() change: only affects Vim9 script.

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 08:21:17 +08:00
zeertzjq
e03f23189d vim-patch:8.2.1274: Vim9: no error for missing white space at script level
Problem:    Vim9: no error for missing white space in assignment at script
            level.
Solution:   Check for white space. (closes vim/vim#6495)

63be3d4ba0

Cherry-pick Test_let_errors() change from patch 8.2.0633.

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-06 08:21:08 +08:00
zeertzjq
83ea9e23a2 vim-patch:9.0.0835: the window title is not redrawn when 'endoffile' changes (#20951)
Problem:    The window title is not redrawn when 'endoffile' changes.
Solution:   redraw the window title when 'endoffile' is changed. (Ken Takata,
            closes vim/vim#11488)

845bbb72ed

Co-authored-by: K.Takata <kentkt@csc.jp>
2022-11-06 05:47:57 +08:00
dundargoc
01ff681f57 Merge pull request #20858 from dundargoc/build/lintsh
build: add more shell scripts to the `lintsh` target
2022-11-05 22:11:22 +01:00
zeertzjq
d5dd7573f3 vim-patch:8.2.3713: MS-Windows: no error if vimgrep pattern is not matching (#20947)
Problem:    MS-Windows: No error message if vimgrep pattern is not matching.
Solution:   Give an error message. (Christian Brabandt, closes vim/vim#9245,
            closes vim/vim#8762)

0b226f60be

Co-authored-by: Christian Brabandt <cb@256bit.org>
2022-11-06 05:02:57 +08:00
zeertzjq
13381692cd vim-patch:8.2.1417: test 49 is old style
Problem:    Test 49 is old style.
Solution:   Convert more parts to new style test. (Yegappan Lakshmanan,
            closes vim/vim#6682)

efb6482949
2022-11-05 21:38:36 +08:00
zeertzjq
8d6a217b9a vim-patch:8.2.1383: test 49 is old style
Problem:    Test 49 is old style.
Solution:   Convert test cases to new style. (Yegappan Lakshmanan,
            closes vim/vim#6638)

9470a4d88a

Cherry-pick AssertException() from patch 8.2.1146.
2022-11-05 21:38:36 +08:00
zeertzjq
42e7c7fc9c vim-patch:8.2.1366: test 49 is old style
Problem:    Test 49 is old style.
Solution:   Convert several tests to new style. (Yegappan Lakshmanan,
            closes vim/vim#6629)

a6296200bd
2022-11-05 21:38:36 +08:00
zeertzjq
01ccfb40e3 vim-patch:8.2.1106: crash when trying to use s: variable in typed command
Problem:    Crash when trying to use s: variable in typed command.
Solution:   Don't use the script index when not set. (Ken Takata,
            closes vim/vim#6366)

8e6cbb7232
2022-11-05 21:38:36 +08:00
zeertzjq
cb8bc9b33c vim-patch:8.2.0883: memory leak in test 49
Problem:    Memory leak in test 49.
Solution:   Free "sfile" from the exception.

5fbf3bc3f9

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-05 21:38:29 +08:00
zeertzjq
e0ec83a970 vim-patch:8.2.4882: cannot make 'breakindent' use a specific column
Problem:    Cannot make 'breakindent' use a specific column.
Solution:   Add the "column" entry in 'breakindentopt'. (Christian Brabandt,
            closes vim/vim#10362, closes vim/vim#10325)

e7d6dbc572

Co-authored-by: Christian Brabandt <cb@256bit.org>
2022-11-05 19:35:56 +08:00
zeertzjq
6374120558 vim-patch:8.2.4501: with 'showbreak' set cursor displayed in wrong position
Problem:    With 'showbreak' set and after the end of the line the cursor
            may be displayed in the wrong position.
Solution:   Do not apply 'showbreak' after the end of the line. (closes vim/vim#9884)

21efafe4c2

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-05 19:35:56 +08:00
zeertzjq
8b43091392 vim-patch:8.2.4100: early return when getting the 'formatlistpat' value
Problem:    Early return when getting the 'formatlistpat' value.
Solution:   Remove the first line. (Christian Brabandt)
04b871da80
2022-11-05 19:35:56 +08:00
zeertzjq
b92ed35a0b vim-patch:8.2.4093: cached breakindent values not initialized properly
Problem:    Cached breakindent values not initialized properly.
Solution:   Initialize and cache formatlistpat. (Christian Brabandt,
            closes vim/vim#9526, closes vim/vim#9512)
c53b467473

Co-authored-by: Christian Brabandt <cb@256bit.org>
2022-11-05 19:35:56 +08:00
zeertzjq
3e60b9f1cc vim-patch:8.2.4029: debugging NFA regexp my crash, cached indent may be wrong
Problem:    Debugging NFA regexp my crash, cached indent may be wrong.
Solution:   Fix some debug warnings in the NFA regexp code.  Make sure log_fd
            is set when used.  Fix breakindent and indent caching. (Christian
            Brabandt, closes vim/vim#9482)
b2d85e3784
2022-11-05 19:35:56 +08:00
zeertzjq
3c0651fb45 fix(eval): make error number of charidx() same as Vim 2022-11-05 18:06:00 +08:00
zeertzjq
8e868d699a vim-patch:8.2.4679: cannot have expandcmd() give an error message for mistakes
Problem:    Cannot have expandcmd() give an error message for mistakes.
Solution:   Add an optional argument to give errors. Fix memory leak when
            expanding files fails. (Yegappan Lakshmanan, closes vim/vim#10071)
2b74b6805b

Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
2022-11-05 18:06:00 +08:00
zeertzjq
781616bee5 vim-patch:8.2.2606: strchars() defaults to counting composing characters
Problem:    strchars() defaults to counting composing characters.
Solution:   Add strcharlen() which ignores composing characters.

70ce8a1561

Use docs from latest Vim instead.

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-05 18:06:00 +08:00
zeertzjq
451850920b vim-patch:8.2.1626: test for strchars() fails with different error number
Problem:    Test for strchars() fails with different error number.
Solution:   Adjust the error number.

707be5f352

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-05 18:06:00 +08:00
zeertzjq
d857569dbd vim-patch:8.2.1624: Vim9: cannot pass "true" to split(), str2nr() and strchars()
Problem:    Vim9: cannot pass "true" to split(), str2nr() and strchars().
Solution:   Use tv_get_bool_chk(). (closes vim/vim#6884, closes vim/vim#6885, closes vim/vim#6886)

3986b94b09

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-05 18:06:00 +08:00
zeertzjq
38c113ae84 vim-patch:8.2.1600: Vim9: cannot use "true" with deepcopy()
Problem:    Vim9: cannot use "true" with deepcopy().
Solution:   Use tv_get_bool_chk(). (closes vim/vim#6867)

44b4a246b6

Co-authored-by: Bram Moolenaar <Bram@vim.org>
2022-11-05 18:06:00 +08:00