Commit Graph

15506 Commits

Author SHA1 Message Date
dundargoc
b0fcdf9f09 vim-patch:9.0.0576: unused loop variables (#20326)
Problem:    Unused loop variables.
Solution:   Use a while loop instead. (closes vim/vim#11214)
b2209f213e
2022-09-25 06:07:59 +08:00
zeertzjq
8317b9199e fix(input): use click number of last click for mouse drag (#20300) 2022-09-24 22:28:41 +08:00
zeertzjq
0c77dba9a4 vim-patch:9.0.0572: insert complete tests leave a mapping behind
Problem:    Insert complete tests leave a mapping behind.
Solution:   Use a buffer-local mapping. (closes vim/vim#11211)
75f4bafabd
2022-09-24 21:17:03 +08:00
zeertzjq
57b731818d vim-patch:9.0.0567: 'completeopt' "longest" is not used for complete()
Problem:    'completeopt' "longest" is not used for complete().
Solution:   Also use "longest" for complete(). (Bjorn Linse, closes vim/vim#11206)
87af60c915
2022-09-24 21:16:43 +08:00
zeertzjq
291a649632 fix(mapset): remove existing abbreviation of same lhs (#20320) 2022-09-24 21:07:18 +08:00
zeertzjq
db056de29a vim-patch:9.0.0568: autocmd code is indented more than needed (#20318)
Problem:    Autocmd code is indented more than needed.
Solution:   Break out sooner. (Yegappan Lakshmanan, closes vim/vim#11208)
            Also in user function code.
e9dcf13a30
2022-09-24 19:20:03 +08:00
Christian Clason
f8b656c582 vim-patch:9.0.0566: Nim files are not recognized (#20317)
Problem:    Nim files are not recognized.
Solution:   Add patterns for Nim files. (Nbiba Bedis, closes vim/vim#11205)
9fd1583c83
2022-09-24 12:59:37 +02:00
Christian Clason
24b5449b3d vim-patch:9.0.0562: HSL playlist files are not recognized (#20307)
Problem:    HSL playlist files are not recognized.
Solution:   Add a pattern to recognize HSL palylist files. (Benoît Ryder,
            closes vim/vim#11204)
35fdd9a67d
2022-09-24 10:16:30 +02:00
zeertzjq
f3c842058e vim-patch:9.0.0559: timer test may get stuck at hit-enter prompt (#20312)
Problem:    Timer test may get stuck at hit-enter prompt.
Solution:   Feed some more characters.
4ecf16bbf9
2022-09-24 08:10:49 +08:00
zeertzjq
c28f00b101 vim-patch:9.0.0550: crash when closing a tabpage and buffer is NULL
Problem:    Crash when closing a tabpage and buffer is NULL.
Solution:   Adjust how autocommands are triggered when closing a window.
            (closes vim/vim#11198, closes vim/vim#11197)
62de54b48d
2022-09-23 07:38:22 +08:00
zeertzjq
4371886293 vim-patch:9.0.0544: minor issues with setting a string option
Problem:    Minor issues with setting a string option.
Solution:   Adjust the code, add a test. (closes vim/vim#11192)
fcba86c031
2022-09-22 21:09:31 +08:00
zeertzjq
33f1471472 vim-patch:9.0.0540: assigning stack variable to argument confuses Coverity
Problem:    Assigning stack variable to argument confuses Coverity.
Solution:   Use a local pointer, also makes the code simpler.
6f98114e4a
2022-09-22 21:07:54 +08:00
zeertzjq
2083c1771a fix(window): close floats first when closing buffer in other tab (#20284) 2022-09-22 20:25:34 +08:00
zeertzjq
a7f6f0e2dd vim-patch:9.0.0539: long message test can be flaky (#20282)
Problem:    Long message test can be flaky.
Solution:   Wait for more prompt instead of ruler.
21d393a12b

Comment N/A lines out instead of deleting in buftype tests.
2022-09-22 20:18:06 +08:00
bfredl
93b30582db fix(redraw): make redrawdebug=nodelta handle all the cases
Before only win_line lines were considered. this applies nodelta
to all screen elements. Causes some failures, which might indeed
indicate excessive redraws.
2022-09-22 10:38:10 +02:00
bfredl
00cfc1dceb fix(redraw): avoid unnecessary redraws and glitches with floats+messages
fixes #20106
fixes #20229
2022-09-22 10:36:23 +02:00
zeertzjq
477cf2a6b1 vim-patch:8.2.4677: the Athena GUI support is outdated
Problem:    The Athena GUI support is outdated.
Solution:   Remove the Athena GUI code.
0b962e5685
2022-09-22 13:23:58 +08:00
zeertzjq
1bced9bf94 vim-patch:8.2.4074: going over the end of NameBuff
Problem:    Going over the end of NameBuff.
Solution:   Check length when appending a space.
de05bb2573
2022-09-22 13:17:43 +08:00
zeertzjq
a636e24280 vim-patch:8.2.3568: ctrl-hat test fails with Athena and Motif
Problem:    Ctrl-hat test fails with Athena and Motif. (Elimar Riesebieter)
Solution:   Run the test only with GTK. (Dominique Pellé, closes vim/vim#9069)
8753c1dd2c
2022-09-22 13:15:40 +08:00
zeertzjq
320e56a4e0 vim-patch:8.2.3567: CTRL-I in Insert mode is not tested
Problem:    CTRL-I in Insert mode is not tested
Solution:   Add a test case. (Dominique Pellé, closes vim/vim#8866)
9cd063e319
2022-09-22 13:15:12 +08:00
zeertzjq
3f4030e171 vim-patch:8.2.3428: using freed memory when replacing
Problem:    Using freed memory when replacing. (Dhiraj Mishra)
Solution:   Get the line pointer after calling ins_copychar().
35a9a00afc

This patch is N/A as it only applies to non-UTF-8 encoding.
2022-09-22 13:13:11 +08:00
zeertzjq
800cda2164 vim-patch:8.2.3155: some option related code not covered by tests
Problem:    Some option related code not covered by tests.
Solution:   Add a few test cases. (Dominique Pellé, closes vim/vim#8552)
042414fa00
2022-09-22 12:40:26 +08:00
zeertzjq
88099c1122 vim-patch:8.2.2994: various code is not fully tested
Problem:    Various code is not fully tested.
Solution:   Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#8378)
2d6d718dde

Nvim does not support encoding=latin1 or compatible mode.
The two paste tests are applicable.
2022-09-22 12:40:26 +08:00
zeertzjq
dd2b7586f3 vim-patch:8.2.2979: not all options code is covered by tests
Problem:    Not all options code is covered by tests.
Solution:   Add more tests for options. (Yegappan Lakshmanan, closes vim/vim#8369)
5958549760
2022-09-22 12:40:26 +08:00
zeertzjq
5d1cb73e7f vim-patch:8.2.0712: various code not fully tested
Problem:    Various code not fully tested.
Solution:   Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#6049)
0ff5dedf0f

Nvim does not support encoding=latin1 or setting keycodes/termcaps.
2022-09-22 12:40:26 +08:00
zeertzjq
71e70d0c99 vim-patch:9.0.0537: the do_set() function is much too long (#20274)
Problem:    The do_set() function is much too long.
Solution:   Move setting of a string option to a separate function.
4740394f23

Cherry-pick some tests from Vim patch 8.2.0540.
2022-09-22 09:43:37 +08:00
zeertzjq
37a71d1f28 vim-patch:9.0.0018: going over the end of the typahead (#20269)
Problem:    Going over the end of the typahead.
Solution:   Put a NUL after the typeahead.
27efc62f5d

check_termcode() is N/A.
2022-09-21 11:06:39 +08:00
zeertzjq
ad1f353fe1 vim-patch:9.0.0517: when at the command line :redrawstatus does not work well (#20266)
Problem:    When at the command line :redrawstatus does not work well.
Solution:   Only update the statuslines instead of the screen. (closes vim/vim#11180)
320d910064
2022-09-21 06:47:29 +08:00
zeertzjq
585ab2564a refactor: suppress PVS false positives (#20264)
Some V512 warnings have changed to V1086, and PVS apparently does not
know `uv_run()` can change `*timeout_expired`.
2022-09-21 06:02:53 +08:00
bfredl
62db91f06c Merge pull request #20263 from notomo/refactor-remove-unused
refactor(message): remove unused function
2022-09-20 16:38:31 +02:00
zeertzjq
cfdc93e8ac vim-patch:9.0.0511: unnecessary scrolling for message of only one line (#20261)
Problem:    Unnecessary scrolling for message of only one line.
Solution:   Only set msg_scroll when needed. (closes vim/vim#11178)
bdedd2bcce
2022-09-20 21:58:39 +08:00
notomo
b5a21ad8ff refactor(message): remove unused function 2022-09-20 13:07:48 +00:00
zeertzjq
2e4532bea5 vim-patch:9.0.0512: cannot redraw the status lines when editing a command
Problem:    Cannot redraw the status lines when editing a command.
Solution:   Only postpone the redraw when messages have scrolled.
            (closes vim/vim#11170)
c14bfc31d9
2022-09-20 21:01:00 +08:00
zeertzjq
9413f7544b vim-patch:9.0.0507: cmdline cleared when using :redrawstatus in CmdlineChanged
Problem:    Command line cleared when using :redrawstatus in CmdlineChanged
            autocommand event.
Solution:   Postpone the redraw. (closes vim/vim#11162)
bcd6924245

Cherry-pick Test_redraw_in_autocmd() from Vim patch 8.2.4789.
2022-09-20 21:00:45 +08:00
Christian Clason
ae30e388de vim-patch:9.0.0510: Chatito files are not recognized (#20260)
Problem:    Chatito files are not recognized.
Solution:   Add a pattern for Chatito files. (closes vim/vim#11174)
7c046ae99b
2022-09-20 14:10:00 +02:00
zeertzjq
054c27075b vim-patch:9.0.0509: confusing error for "saveas" command with "nofile" buffer (#20258)
Problem:    Confusing error for "saveas" command with "nofile" buffer.
Solution:   Give a clearer error message. (closes vim/vim#11171)
500a1f9972
2022-09-20 19:49:00 +08:00
zeertzjq
a0e6e767a6 fix(tui): handle padding requirements for visual bell (#20238) 2022-09-20 11:47:04 +08:00
zeertzjq
7bd4c8e8ee fix(inccommand): avoid unnecessary redraw when not showing (#20244) 2022-09-19 12:37:25 +08:00
zeertzjq
647da34bbd fix: assert failure when changing 'ut' while waiting for CursorHold (#20241) 2022-09-18 22:55:30 +08:00
Christian Clason
8dc61713d9 vim-patch:9.0.0497: LyRiCs files are not recognized (#20239)
Problem:    LyRiCs files are not recognized.
Solution:   Add a pattern to detect LyRiCs files. (closes vim/vim#11155)
65ee49decf
2022-09-18 14:16:24 +02:00
bfredl
e63538f21c Merge pull request #20198 from zeertzjq/cursorhold
fix(events): make CursorHold behave as documented
2022-09-18 11:37:22 +02:00
dundargoc
6d557e324f vim-patch:8.1.0941: macros for MS-Windows are inconsistent (#20215)
Problem:    Macros for MS-Windows are inconsistent, using "32", "3264 and
            others.
Solution:   Use MSWIN for all MS-Windows builds.  Use FEAT_GUI_MSWIN for the
            GUI build. (Hirohito Higashi, closes vim/vim#3932)
4f97475d32
2022-09-18 09:17:15 +08:00
zeertzjq
644a3f48b1 fix(events): make CursorHold behave as documented 2022-09-17 21:48:44 +08:00
zeertzjq
18139a69bc vim-patch:8.2.0690: line number of option set by modeline is wrong (#20228)
Problem:    Line number of option set by modeline is wrong.
Solution:   Do not double the line number. (Ozaki Kiichi, closes vim/vim#6035)
5125874951
2022-09-17 15:39:04 +08:00
zeertzjq
72e1041429 vim-patch:9.0.0483: illegal memory access when replacing in virtualedit mode (#20225)
Problem:    Illegal memory access when replacing in virtualedit mode.
Solution:   Check for replacing NUL after Tab.
c249913edc

Cherry-pick Test_virtualedit_mouse() from patch 9.0.0177.
2022-09-17 10:20:06 +08:00
zeertzjq
26b54d5c16 test(old): add a function roughly equivalent to test_setmouse() (#20224)
Mouse movement events usually have no effect, so passing "move" to
nvim_input_mouse() works in most cases.
2022-09-17 09:40:19 +08:00
Christian Clason
e512d3ecf2 vim-patch:9.0.0479: in :def function all closures in loop get the sam… (#20220)
vim-patch:9.0.0479: in :def function all closures in loop get the same variables

Problem:    In a :def function all closures in a loop get the same variables.
Solution:   Use a separate list of variables for LOADOUTER and SAVEOUTER.
1aea184a0d

(note: patch description is wrong)
2022-09-16 17:52:08 +02:00
zeertzjq
6b2f0f43b5 fix(eval)!: make Lua Funcref work as method and in substitute() (#20217)
BREAKING CHANGE: When using a Funcref converted from a Lua function as
a method in Vim script, the result of the base expression is now passed
as the first argument instead of being ignored.

vim-patch:8.2.5117: crash when calling a Lua callback from a :def function

Problem:    Crash when calling a Lua callback from a :def function. (Bohdan
            Makohin)
Solution:   Handle FC_CFUNC in call_user_func_check(). (closes vim/vim#10587)
7d149f899d
2022-09-16 23:09:26 +08:00
zeertzjq
a0642ec75e feat(tui): support undercurl when Konsole version >= 221170 (#20219)
Support was added in 76f879cd70
2022-09-16 22:40:04 +08:00
zeertzjq
622968d7b3 vim-patch:9.0.0476: varargs does not work for replacement function of substitute() (#20216)
Problem:    Varargs does not work for replacement function of substitute().
Solution:   Check the varargs flag of the function. (closes vim/vim#11142)
48db5dafec
2022-09-16 19:40:52 +08:00