mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-02 16:08:36 +00:00
Code Issues Packages Projects Releases Wiki Activity
19,732 Commits 10 Branches 54 Tags
51306f98b8e35d056c3d12c7a9973a0fa92f8172
Commit Graph

12301 Commits

Author SHA1 Message Date
Jan Edmund Lazo
cd4b649136 vim-patch:8.2.2185: BufUnload is not triggered for the quickfix dummy buffer 
Problem:    BufUnload is not triggered for the quickfix dummy buffer.
Solution:   Do trigger BufUnload. (Pontus Leitzler,closes vim/vim#7518, closes vim/vim#7517)
            Fix white space around "=".
1cfb9bb5c0
 2021-06-23 23:16:20 -04:00
Jan Edmund Lazo
4cb0bf0942 vim-patch:8.2.1255: cannot use a lambda with quickfix functions 
Problem:    Cannot use a lambda with quickfix functions.
Solution:   Add support for lambda. (Yegappan Lakshmanan, closes vim/vim#6499)
d43906d2e5
 2021-06-23 23:16:20 -04:00
Jan Edmund Lazo
d5329c0331 vim-patch:8.1.1437: code to handle callbacks is duplicated 
Problem:    Code to handle callbacks is duplicated.
Solution:   Add callback_T and functions to deal with it.
3a97bb3f0f

Port Vim's put_callback() as callback_put()
because Neovim's naming convention is {type}_{action},
not {action}_{type}.

Renaming put_callback type as PutCallback.
https://neovim.io/develop/style-guide.xml#Type_Names
 2021-06-23 23:16:20 -04:00
Björn Linse
24e0c16fd6 Merge pull request #14868 from shadmansaleh/patch_verbose_for_lua 
fix(runtime): Fix bugs regarding lua runtime files
 2021-06-23 20:34:57 +02:00
snezhniylis
43479f0ad6 extmark: fix deletable nodes in MarkTree sometimes getting skipped 
As per #14236, performing extmark cleanup in a certain namespace does
not guarantee removing all the extmarks inside given namespace.
The issue resides within the tree node removal method and results in
a couple of rare edge cases.

To demonstrate what causes this bug, I'll give an example covering one
of the edge cases.

=== AN EXAMPLE ===

   (A)         (B)         (C)         (D)         (E)
---------   ---------   ---------   ---------   ---------
  <0, 1>      <0, 1>      <0, 1>      <0, 1>      <0, 1>
  <0, 2>      <0, 2>      <0, 2>      <0, 2>      <0, 2>
  <0, 3>      <0, 3>      <0, 3>      <0, 3>      <0, 3>
  <0, 4>      <0, 4>      <0, 4>      <0, 4>      <0, 4>
  <0, 5>      <0, 5>      <0, 5>      <0, 5>      <0, 5>
  <0, 6>      <0, 6>      <0, 6>      <0, 6>      <0, 6>
  <0, 7>      <0, 7>      <0, 7>      <0, 7>      <0, 7>
  <0, 8>      <0, 8>      <0, 8>      <0, 8>      <0, 8>
  <0, 9>      <0, 9> *           *    <0, 9>  *   <0, 9>
[0, 10] *   [0, 10]     <0, 9>        [0, 11]     [0, 11]
  [0, 11]     [0, 11]     [0, 11]     [0, 12]     [0, 12]  *
  [0, 12]     [0, 12]     [0, 12]     [0, 13]     [0, 13]
  [0, 13]     [0, 13]     [0, 13]     [0, 14]     [0, 14]
  [0, 14]     [0, 14]     [0, 14]     [0, 15]     [0, 15]
  [0, 15]     [0, 15]     [0, 15]     [0, 16]     [0, 16]
  [0, 16]     [0, 16]     [0, 16]     [0, 17]     [0, 17]
  [0, 17]     [0, 17]     [0, 17]     [0, 18]     [0, 18]
  [0, 18]     [0, 18]     [0, 18]     [0, 19]     [0, 19]
  [0, 19]     [0, 19]     [0, 19]   [0, 20]     [0, 20]
[0, 20]     [0, 20]     [0, 20]

DIAGRAM EXPLANATION

* Every column is a state of the marktree at a certain stage.

* To make it simple, I don't draw the whole tree. What you see are
   2 leftmost parent nodes ([0, 10], [0, 20]) and their children placed
   in order `MarkTreeIter` would iterate through. From top to bottom.

* Numbers on this diagram represent extmark coordinates. Relative
   positioning and actual mark IDs used by the marktree are avoided
   for simplicity.

* 2 types of brackets around coordinates represent 2 different
   extmark namespaces (`ns_id`s).

* '*' shows iterator position.

ACTUAL EXPLANATION

Let's assume, we have two sets of extmarks from 2 different plugins:
  * Plugin1: <0, 1-9>
  * Plugin2: [0, 10-20]

1. Plugin2 calls
    `vim.api.nvim_buf_clear_namespace(buf_handle, ns_id, 0, -1)`
    to clear all its extmarks which results in `extmark_clear` call.

2. The iteration process goes on ignoring extmarks with irrelevant
    `ns_id` from Plugin1, until it reaches [0, 10], entering state (A).

3. At the end of cleaning up process, `marktree_del_itr` gets called.
    This function is supposed to remove given node and, if necessary,
    restructure the tree. Also, move the iterator to the next node.
    The bug occurs in this function.

4. The iterator goes backwards to the node's last child, to put it
    in the place of its deleted parent later. (B)

5. The parent node is deleted and replaced with its child node. (C)

6. Since now this node has 8 children, which is less than
    `MT_BRANCH_FACTOR - 1`, it get's merged with the next node. (D)

7. Finally, since at (B) the iterator went backward, it goes forward
    twice, skipping [0, 11] node, causing this extmark to persist,
    causing the bug. (E)

ANALYSIS AND SOLUTION

The algorithm works perfectly when the parent node gets replaced by
its child, but no merging occurs. I.e. the exact same diagram,
but without the (D) stage. If not for (D), it would iterate to <0, 9>
and then to [0, 11]. So, iterating twice makes sense. The actual problem
is in (C) stage, because the iterator index isn't adjusted and still
pointing to no longer existent node. So my solution is to adjust
iterator index after removing the child node.

More info: https://github.com/neovim/neovim/pull/14719
 2021-06-22 10:32:46 +02:00
shadmansaleh
b4ac878026 fix(source): Source giving E484 & parsing error at line 1 for lua files 
It's happening because do_source is only expected to return FAIL when it
was unable to open file . But `nlua_exec_file` returns fail for parsing
and execution error too . Those errors are emitted through `nlua_error`.

So now return value of nlua_exec_file is ignored like do_cmdline. It now
only returns fail when it was unable to open file that check is done
before calling nlua_exec_file or do_cmdline. Errors in nlua_exec_file
are still directly emitted through nlua_error like before.
 2021-06-21 13:07:05 +06:00
shadmansaleh
b4a216f7ed BugFix: Fix inconsistent verbose message 
When a keymap is set from lua currently verbose message says
it's set from line 1. That's incorrect because we don't really know when
it was set. So until proper :verbose support isn't added for sourceing
lua it shouldn't say where it was set at.
 2021-06-21 07:14:37 +06:00
jimman2003
b585f723bc vim-patch:8.2.3020: unreachable code (#14866) 
Problem:    Unreachable code.
Solution:   Remove the code. (closes vim/vim#8406)
2fb7495686
 2021-06-20 14:20:43 -04:00
Sean Dewar
5f1b728621 fix(api/win_get_config): include z-index 2021-06-19 17:17:17 +01:00
Björn Linse
96d83e2a66 Merge pull request #14824 from vigoux/extmarks-ts-perf 
perf(extmarks): allow ephemeral extmarks past EOF to remove O(strlen^2) cost of tree-sitter
 2021-06-18 12:37:27 +02:00
Jan Edmund Lazo
e2d3ad7bc4 vim-patch:8.2.3012: when 'rightleft' is set the line number is drawn reversed (#14839) 
Problem:    When 'rightleft' is set the line number is sometimes drawn
            reversed.
Solution:   Adjust how space is handled. (Christian Brabandt, closes vim/vim#8389,
            closes vim/vim#8391)
29f0dc3689
 2021-06-17 22:00:26 -04:00
Thomas Vigouroux
a85e8a186b perf(extmarks): allow ephemeral extmarks past EOF 2021-06-16 20:15:47 +02:00
Thomas Vigouroux
6a77def1ee Merge pull request #14454 from eltociear/patch-1 
screen: fix typo in screen.c
 2021-06-15 20:06:41 +02:00
Ikko Ashimine
dbf8236764 option: fix typo in option.c 
seperated -> separated
 2021-06-16 01:08:23 +09:00
Michael Lingelbach
4284abd89a Merge pull request #14804 from clason/rounded-borders 
[RDY] feat(float): add rounded borders preset
 2021-06-14 13:36:47 -07:00
Christian Clason
5b6edc852f feat(float): add rounded borders preset 
Add `borders = "rounded"` preset for `nvim_open_win`, equivalent to

  border = {"╭", "─", "╮", "│", "╯", "─", "╰", "│"}

Also add undocumented "solid" preset to docs.
 2021-06-14 11:10:57 +02:00
Jan Edmund Lazo
8f4ba0a46b vim-patch:8.2.2990: Jupyter Notebook files are not recognized 
Problem:    Jupyter Notebook files are not recognized.
Solution:   Recognize *.ipynb. (closes vim/vim#8375)
2e66b0d137
 2021-06-13 15:27:24 -04:00
Jan Edmund Lazo
ac18e26f57 vim-patch:8.2.0936: some terminals misinterpret the code for getting cursor style 
Problem:    Some terminals misinterpret the code for getting cursor style.
Solution:   Send a sequence to the terminal and check the result. (IWAMOTO
            Kouichi, closes vim/vim#2126)  Merged with current code.
a45551a535

Cherry-pick Test_cwindow_highlight() from patch v8.1.2040
because it is skipped.
 2021-06-13 12:34:23 -04:00
Jan Edmund Lazo
8b81218300 vim-patch:8.2.1354: test 59 is old style 
Problem:    Test 59 is old style.
Solution:   Convert into a new style test. (Yegappan Lakshmanan, closes vim/vim#6604)
aa970abd0a
 2021-06-13 10:19:48 -04:00
Björn Linse
9c7132cda4 Merge pull request #14788 from shadmansaleh/fix/lua_runtime1 
fixup(runtime): Fix lua runtime files not listed in :scriptnames
 2021-06-13 00:52:30 +02:00
shadmansaleh
cdbc733ec4 refactor(startup): Load init.lua with do_sorce 
This was init.lua will be logged in startuptime
 2021-06-13 00:27:52 +06:00
shadmansaleh
1f280b582f fixup(runtime): Fix lua runtime files not listed 
lua runtime files weren't listed in :scriptname & profiler.
This fixes that.

* Add tests

* Small doc tweeks
 2021-06-13 00:27:52 +06:00
Jan Edmund Lazo
6a4685fb0e vim-patch:8.2.2896: spellfile functionality not fully tested 
Problem:    Spellfile functionality not fully tested.
Solution:   Add tests for CHECKCOMPOUNDPATTERN and COMMON. (Dominique Pellé,
            closes vim/vim#8270)
dc3275a1ac
 2021-06-12 13:06:50 -04:00
Jan Edmund Lazo
72b512bd53 vim-patch:8.2.0945: cannot use "z=" when 'spell' is off 
Problem:    Cannot use "z=" when 'spell' is off.
Solution:   Make "z=" work even when 'spell' is off. (Christian Brabandt,
            Gary Johnson, closes vim/vim#6227)
152e79e94b
 2021-06-12 13:06:50 -04:00
Jan Edmund Lazo
82d1c29bfd vim-patch:8.2.0046: tests for spell suggestions are slow 
Problem:    Tests for spell suggestions are slow.
Solution:   Use shorter words. Test with latin1 and utf-8 to cover more code.
            (Dominique Pelle, closes vim/vim#5399)
767340574b
 2021-06-12 13:06:49 -04:00
Jan Edmund Lazo
e78656875d vim-patch:8.2.0039: memory access error when "z=" has no suggestions 
Problem:    Memory access error when "z=" has no suggestions.
Solution:   Check for negative index.
569fea2c31
 2021-06-12 13:06:49 -04:00
Jan Edmund Lazo
f376e67a53 vim-patch:8.2.0038: spell suggestions insufficiently tested 
Problem:    Spell suggestions insufficiently tested.
Solution:   Add spell suggestion tests. (Dominique Pelle, closes vim/vim#5398)
e9a8d1f9ad

Requires latest en.utf-8.spl from
https://ftp.nluug.nl/pub/vim/runtime/spell/.

Include the following patch because patch v8.2.0946 was merged:

vim-patch:8.2.0948: spell test fails

Problem:    Spell test fails.
Solution:   Adjust expected text of the prompt.
d281b7c227
 2021-06-12 13:06:49 -04:00
Jan Edmund Lazo
e75244af63 vim-patch:8.1.1865: spellrare and spellrepall in the wrong order 
Problem:    Spellrare and spellrepall in the wrong order.
Solution:   Put spellrare below spellrepall. (closes vim/vim#4820)
a3891681f7
 2021-06-12 13:06:49 -04:00
Jan Edmund Lazo
61117d89a3 vim-patch:8.1.1838: there is :spellwrong and :spellgood but not :spellrare 
Problem:    There is :spellwrong and :spellgood but not :spellrare.
Solution:   Add :spellrare. (Martin Tournoij, closes vim/vim#4291)
08cc374dab
 2021-06-12 13:06:48 -04:00
Serg Tereshchenko
8d23941af8 fix(ui): Fix pum incorrect position in multigrid mode 
Refs #12985
 2021-06-12 14:34:02 +02:00
Jan Edmund Lazo
d09b8ad715 Merge pull request #14761 from janlazo/vim-8.2.2966 
vim-patch:8.2.{1702,2422,2966,2971,2974}
 2021-06-11 21:07:47 -04:00
Jan Edmund Lazo
2644fe5b7c vim-patch:8.2.2974: Greek spell checking uses wrong case folding 
Problem:    Greek spell checking uses wrong case folding.
Solution:   Fold capital sigma depending on whether it is at the end of a
            word or not. (closes vim/vim#299)
4f13527598
 2021-06-11 17:00:14 -04:00
Michael Lingelbach
a9b8c780fe Merge pull request #14773 from mjlbach/fix/vim-region-bounds 
fix(lua): ensure vim.region truncates to buf range
 2021-06-11 10:24:30 -07:00
Björn Linse
81a6b70880 Merge pull request #14686 from shadmansaleh/feat/evaluate_plugin/lua 
runtime: allow to use .lua files for most features defined as &rtp/{feature}/*.vim
 2021-06-11 17:42:21 +02:00
Björn Linse
4eeefb8d45 macros: add a dummy statement to allow FALLTHROUGH in an empty case. 2021-06-11 12:07:07 +02:00
Michael Lingelbach
cd3233c289 fix(lua): ensure vim.region truncates to buf range 
If vim.region receives a large range outside of the current buffer
bounds, it will not check the range ahead of time and loop until neovim
exhausts the system memory.

Fixes #14743
 2021-06-11 04:10:01 -04:00
Jan Edmund Lazo
8ebbeee1d0 vim-patch:8.2.2971: cannot yank a block without trailing spaces 
Problem:    Cannot yank a block without trailing spaces.
Solution:   Add the "zy" command. (Christian Brabandt, closes vim/vim#8292)
544a38e44d
 2021-06-10 22:58:15 -04:00
Jan Edmund Lazo
d662dfde36 vim-patch:8.2.2422: crash when deleting with line number out of range 
Problem:    Crash when deleting with line number out of range. (Houyunsong)
Solution:   Avoid using a negative line number.
1d859e2421
 2021-06-10 21:28:30 -04:00
Jan Edmund Lazo
cb368e1bff vim-patch:8.2.1702: crash when using undo after deleting folded lines 
Problem:    Crash when using undo after deleting folded lines.
Solution:   Check for NULL pointer. (closes vim/vim#6968)
da697645d5
 2021-06-10 19:20:33 -04:00
Jan Edmund Lazo
292037ef9b vim-patch:8.2.2966: ml_get errors after recovering a file 
Problem:    ml_get errors after recovering a file. (Yegappan Lakshmanan)
Solution:   Fix the cursor position after deleting lines.
e3f50ad640
 2021-06-10 19:20:32 -04:00
shadmansaleh
e1edc079dd refactor(source): Move lua file detection to do_source 
So now :source can run lua files too :)

* feat: Add support for :[ranged]source for lua files
 2021-06-11 01:01:03 +06:00
shadmansaleh
07c9b20c75 enhance(runtime): Enable completion for lua files 
Enabled for `:colorscheme` `:compiler` filetype
 2021-06-11 01:01:03 +06:00
shadmansaleh
f256a18fef feat(runtime): Allow lua to be used in ftdetect 2021-06-11 01:01:02 +06:00
shadmansaleh
68be8b99cf feat(runtime): Allow lua to be used in compiler 2021-06-11 01:01:02 +06:00
shadmansaleh
1e6c02510a feat(runtime): Allow lua to be used in colorschemes 
* tests(runtime): move runtime/plugin tests to functional/lua/runtime_spec
 2021-06-11 01:01:02 +06:00
shadmansaleh
687eb0b39f feat(startup): Source runtime/plugin/**/*.lua at startup 
For opt plugins these files are sourced on `:packadd`

* `:runtime` Now can exexute lua files
 2021-06-11 00:58:38 +06:00
Björn Linse
7b519cd11c api:get_config: don't add border="none" (inactive default) 2021-06-10 10:41:50 +02:00
Corey Williamson
38d6452899 fix linter errors 2021-06-10 10:41:50 +02:00
Corey Williamson
8021c5a531 api: include border in nvim_win_get_config 2021-06-10 10:41:49 +02:00
Björn Linse
70a1331dab Merge pull request #14717 from notomo/add-win-call-api 
api: add nvim_win_call
 2021-06-10 10:02:31 +02:00