Justin M. Keyes
58dd5fcc01
jobstop(): close channel before process_stop() #10522
...
fix #9799
regression of #7081
Helped-by: Björn Linse <bjorn.linse@gmail.com >
Problem: :UpdateRemotePlugins (which calls rpcstop()) sometimes crashes:
remote/host: python3 host registered plugins []
nvim: ../src/nvim/event/wstream.c:78:
_Bool wstream_write(Stream *, WBuffer *): Assertion `!stream->closed' failed.
Aborted (core dumped)
Order of events (channel 163, see logs below):
1. Channel's in-stream (0x2ba86c0) is **closed** by `f_rpcstop`..`process_stop`.
2. `receive_msgpack` parses the channel out-stream (0x2ba8860)
3. Invokes "nvim_command_output" API method.
4. Writes result to the **closed** in-stream => **abort**
- af993da4355215e3205a
2019-07-17 11:13:57 +02:00
Jan Edmund Lazo
f96dec4a2c
vim-patch:8.1.0715: superfluous redraw_win_later() #10523
...
Problem: Superfluous call to redraw_win_later().
Solution: Remove the call.
6f7e555f74
2019-07-17 11:08:44 +02:00
Justin M. Keyes
bab24a88ab
viml/profile: revert proftime_T to unsigned type #10521
...
- reltimestr(): Produce negative value by comparing the unsigned
proftime_T value to INT64_MAX.
https://github.com/neovim/neovim/issues/10452#issuecomment-511155132
1. The interfaces of nearly all platforms return uint64_t. INT64_MAX is
only half of that.
2. Low-level interfaces like this typically define that there is no
fixed starting point. The only guarantees are that it's (a)
monotonically increasing at a rate that (b) matches real time.
ref 06af88cd72fix #10452
2019-07-16 20:10:08 +02:00
Ihor Antonov
f31f2d0b22
PVS/V1028: cast operands, not the result #10505
2019-07-16 20:03:08 +02:00
Justin M. Keyes
1eea2d236f
Merge #10500 from ngortheone/pvs/V1028_misc1
2019-07-16 20:01:50 +02:00
Ihor Antonov
56bc0a8bed
PVS/V108: cast operands, not the result #10501
2019-07-16 19:58:30 +02:00
Justin M. Keyes
b53b3f7dac
Merge #10493 from ngortheone/pvs/V1028_getchar_918
2019-07-16 19:56:30 +02:00
Justin M. Keyes
b35ad86024
Merge #10391 from janlazo/vim-8.1.0495
...
vim-patch:8.1.{495,505,531,533,583,623,630,641,686,715,833,1012,1221,1651}
2019-07-16 19:52:23 +02:00
Ihor Antonov
b9a2b3f014
PVS/V1028: cast operands, not the result #10503
2019-07-16 19:50:01 +02:00
Ihor Antonov
96e87c5a63
lint
2019-07-16 08:32:09 -04:00
Ihor Antonov
6262d82d2f
pvs/V1028: cast operands, not the result
2019-07-16 08:28:50 -04:00
Justin M. Keyes
583c35714c
Merge #10520 'PVS/V1037: redundant case-branches'
2019-07-16 11:32:35 +02:00
Ihor Antonov
6316247da3
PVS/V1028: cast operands, not the result #10502
2019-07-16 11:23:58 +02:00
Björn Linse
8a3f8589a3
Merge pull request #10504 from bfredl/hl_def
...
highlight: expose builtin highlight groups using hl_group_set event
2019-07-16 10:17:29 +02:00
Jan Edmund Lazo
bf919454eb
vim-patch:8.1.0686: when 'y' is in 'cpoptions' yanking for the clipboard changes redo
...
Problem: When 'y' is in 'cpoptions' yanking for the clipboard changes redo.
Solution: Do not use the 'y' flag when "gui_yank" is TRUE. (Andy Massimino,
closes vim/vim#3760 )
5823f84dd0
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
5be40b9aad
vim-patch:8.1.0641: no check for out-of-memory when converting regexp
...
Problem: No check for out-of-memory when converting regexp.
Solution: Bail out when lalloc() returns NULL. (John Marriott)
c57463c9c6
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
eace147bb0
vim-patch:8.1.0630: "wincmd p" does not work after using an autocmd window
...
Problem: "wincmd p" does not work after using an autocmd window.
Solution: Store "prevwin" in aco_save_T. (Christian Brabandt, closes vim/vim#3690 )
a42df5934b
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
e95945a157
vim-patch:8.1.0623: iterating through window frames is repeated
...
Problem: Iterating through window frames is repeated.
Solution: Define FOR_ALL_FRAMES. (Yegappan Lakshmanan)
3d1491ed23
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
1c2cfdba88
vim-patch:8.1.0583: using illogical name for get_dict_number()/get_dict_string()
...
Problem: Using illogical name for get_dict_number()/get_dict_string().
Solution: Rename to start with dict_.
8f66717a1f
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
066ef812c2
vim-patch:8.1.1651: suspend test is flaky on some systems
...
Problem: Suspend test is flaky on some systems.
Solution: Wait for the shell prompt to show. (Yee Cheng Chin, closes vim/vim#4632 )
9992244226
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
71018924fc
vim-patch:8.1.0533: screendump tests can be flaky
...
Problem: Screendump tests can be flaky.
Solution: Add VerifyScreenDump to the pattern of flaky tests.
447f6ce8bd
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
5b8d378923
vim-patch:8.1.0531: flaky tests often fail with a common error message
...
Problem: Flaky tests often fail with a common error message.
Solution: Add a pattern to match an error message indicating a flaky test.
dbc0d2163a
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
9108256ad4
vim-patch:8.1.1012: memory leak with E461
...
Problem: Memory leak with E461.
Solution: Clear the typeval. (Dominique Pelle, closes vim/vim#4111 )
ab89d7ab89
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
df6354c223
vim-patch:8.1.0833: memory leak when jumps output is filtered
...
Problem: Memory leak when jumps output is filtered.
Solution: Free the filtered name. (Dominique Pelle, closes vim/vim#3869 )
d93090f41f
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
d27175aa28
vim-patch:8.1.1221: filtering does not work when listing marks
...
Problem: Filtering does not work when listing marks.
Solution: Implement filtering marks. (Marcin Szamotulski, closes vim/vim#3895 )
ad6dc49a75
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
5d933310c8
vim-patch:8.1.0505: filter command test may fail if helplang is not set
...
Problem: Filter command test may fail if helplang is not set.
Solution: Set 'helplang' for the test. (James McCoy, closes vim/vim#3591 )
bd9a0c611c
2019-07-15 23:07:28 -04:00
Jan Edmund Lazo
263d62f628
vim-patch:8.1.0495: :filter only supports some commands
...
Problem: :filter only supports some commands.
Solution: Add :filter support for more commands. (Marcin Szamotulski,
closes vim/vim#2856 )
f86db78fed
2019-07-15 23:07:28 -04:00
Ihor Antonov
9a5183f22d
lint
2019-07-15 21:34:15 -04:00
Ihor Antonov
31d256892e
pvs/V1037: two case-branches perform the same action
2019-07-15 21:32:53 -04:00
Justin M. Keyes
990f99658b
viml/profile: cast os_hrtime() result
...
Temporary measure to avoid QuickBuild CI failure:
8:42:54,702 INFO - Executing post-execute action...
18:42:54,702 ERROR - Step 'master>buildall>build-node?testNode=freebsd-64>build-and-run-tests>build-and-run-tests-parameterized?buildType=Release>configure-neovim-and-build-nvim' is failed: Failed to run command: mkdir -p build/Release && cd build/Release && cmake -G "Unix Makefiles" -DBUSTED_OUTPUT_TYPE=TAP -DMIN_LOG_LEVEL=3 -DCMAKE_BUILD_TYPE=Release -DTRAVIS_CI_BUILD=ON ../.. && gmake VERBOSE=1 nvim unittest-prereqs functionaltest-prereqs
Command return code: 2
Command error output: /usr/home/quickbuild/buildagent/workspace/root/neovim/pull-requests-automated/src/nvim/profile.c:70:27: error: implicit conversion changes signedness: 'proftime_T' (aka 'long') to 'unsigned long' [-Werror,-Wsign-conversion]
STRICT_ADD(os_hrtime(), nsec, &rv, int64_t);
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/usr/home/quickbuild/buildagent/workspace/root/neovim/pull-requests-automated/src/nvim/assert.h:150:26: note: expanded from macro 'STRICT_ADD'
do { *(c) = (t)((a) + (b)); } while (0)
^
1 error generated.
gma...
2019-07-16 02:47:50 +02:00
Ihor Antonov
0156e6b810
PVS/V781: suppress false positive #10516
2019-07-16 02:30:31 +02:00
Ihor Antonov
ec81cfb406
PVS/V1028: cast operands, not the result #10496
2019-07-16 02:27:25 +02:00
Ihor Antonov
8df20ff562
lint
2019-07-15 20:10:35 -04:00
Ihor Antonov
dc0d021d9f
pvs/V1028: cast operands, not the result
2019-07-15 19:59:41 -04:00
Daniel Hahler
b06f29318d
Fix missing CursorHoldI events ( #3758 )
...
Fixes https://github.com/neovim/neovim/issues/3757 .
2019-07-16 01:35:43 +02:00
Ihor Antonov
046deeeaa1
PVS/V1028: cast operands, not the result #10507
2019-07-16 01:01:12 +02:00
Ihor Antonov
de3e2f051e
PVS/V1028: cast operands, not the result #10498
...
The + 1 can be removed. It was used for current_screenline, which
now is dedicated linebuf_char buffer.
2019-07-16 00:55:10 +02:00
erw7
519382646b
Fix is_executable_in_path() on Windows ( #10468 )
...
* Fix problem that 1byte extra memory was allocated in is_executable_in_path
* Revert "Revert "tests: executable_spec: enable pending test #10443 " (#10454 )"
This reverts commit 13fbeda0e5
2019-07-15 17:39:34 +02:00
Ihor Antonov
63ecfc97ef
PVS/V590: redundant condition #10510
2019-07-15 10:52:38 +02:00
Ihor Antonov
5a32db9ad4
PVS/V547: expression is always false #10511
2019-07-15 10:47:35 +02:00
erw7
78f36fcf8c
PVS/V1028: cast operands, not the result #10508
...
fix #10508
2019-07-14 22:16:44 +02:00
Ihor Antonov
47d53d66bd
PVS/V1028: cast operands, not the result #10508
2019-07-14 21:03:06 +02:00
Ihor Antonov
452112ae38
PVS/V1028 ugrid.c:76 ( #10495 )
...
* code review
2019-07-14 15:46:07 +02:00
Björn Linse
857b29bdd8
highlight: expose builtin highlight groups using hl_group_set event
2019-07-14 13:26:40 +02:00
Björn Linse
1e47e3f599
Merge pull request #10497 from bfredl/synlist
...
messages: fix missing newlines in execute("syn list").
2019-07-14 13:11:56 +02:00
Björn Linse
4c6e62d056
syntax: refactor syn_list_header to not use magic value
2019-07-14 09:31:49 +02:00
Björn Linse
c2b3cc970c
syntax: fix missing newlines in execute("syn list"). fixes #10467
2019-07-14 09:31:45 +02:00
Björn Linse
cb9e0a051f
floats: fix 'winblend' on top of doublewidth chars.
...
The interaction between 'winblend' and doublewidth chars in the background
does not look very good. But check no chars get incorrectly placed
at least.
Also check that hidden EndOfBuffer region (from style="minimal") blends
correctly.
2019-07-13 14:27:06 +02:00
Justin M. Keyes
4013f67053
viml/profile: revert gettimeofday() #10488
...
e2ce5ff9d6close #10328
ref #10356
ref #10452
2019-07-13 12:37:58 +02:00
Justin M. Keyes
e1fae8f1fe
Merge #10435 from Shougo/vim-8.1.1610
2019-07-13 12:36:32 +02:00
